Convert setters to properties#236
Merged
psi29a merged 3 commits intoMindwerks:masterfrom Oct 10, 2016
Himura2la:master
Merged
Conversation
Member
|
Any reasons why you did not run the automated tests locally? |
Contributor
Author
|
To be honest, I don't have experience in unit testing. I tried to run |
1 similar comment
Current coverage is 80.94% (diff: 65.71%)@@ master #236 diff @@
==========================================
Files 28 28
Lines 3819 3867 +48
Methods 0 0
Messages 0 0
Branches 764 764
==========================================
+ Hits 3081 3130 +49
+ Misses 546 541 -5
- Partials 192 196 +4
|
Member
|
To me it looks good and tests are passing. I will leave it open to give the possibility to @psi29a to take a look. If I do not hear anything in the next days I am going on to merge this one. In the meantime: @Himura2la thank you very much for your work, it is appreciated! |
Contributor
Author
|
Thanks for your opensource work! |
Member
|
LGTM, merging! :) Thank you very much! |
Member
|
Feel free to add yourself to the list of contributors! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to be helpful and resolve #209
I did not run this project, so the code is need to be carevully reviewed and tested