Skip to content

Convert setters to properties#236

Merged
psi29a merged 3 commits intoMindwerks:masterfrom
Himura2la:master
Oct 10, 2016
Merged

Convert setters to properties#236
psi29a merged 3 commits intoMindwerks:masterfrom
Himura2la:master

Conversation

@Himura2la
Copy link
Contributor

Trying to be helpful and resolve #209
I did not run this project, so the code is need to be carevully reviewed and tested

@ftomassetti
Copy link
Member

Any reasons why you did not run the automated tests locally?

@Himura2la
Copy link
Contributor Author

To be honest, I don't have experience in unit testing. I tried to run python -m unittest but it discovered 0 tests. Maybe that's because I can't install noise==1.2.2, pip throws some random error

@coveralls
Copy link

coveralls commented Oct 8, 2016

Coverage Status

Coverage increased (+0.3%) to 86.036% when pulling 9c6a3c1 on Himura2la:master into d7604c9 on Mindwerks:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 86.036% when pulling 9c6a3c1 on Himura2la:master into d7604c9 on Mindwerks:master.

@codecov-io
Copy link

codecov-io commented Oct 8, 2016

Current coverage is 80.94% (diff: 65.71%)

Merging #236 into master will increase coverage by 0.26%

@@             master       #236   diff @@
==========================================
  Files            28         28          
  Lines          3819       3867    +48   
  Methods           0          0          
  Messages          0          0          
  Branches        764        764          
==========================================
+ Hits           3081       3130    +49   
+ Misses          546        541     -5   
- Partials        192        196     +4   

Powered by Codecov. Last update d7604c9...9c6a3c1

@ftomassetti
Copy link
Member

To me it looks good and tests are passing. I will leave it open to give the possibility to @psi29a to take a look. If I do not hear anything in the next days I am going on to merge this one.

In the meantime: @Himura2la thank you very much for your work, it is appreciated!

@Himura2la
Copy link
Contributor Author

Thanks for your opensource work!

@psi29a
Copy link
Member

psi29a commented Oct 10, 2016

LGTM, merging! :)

Thank you very much!

@psi29a psi29a merged commit 8137436 into Mindwerks:master Oct 10, 2016
@psi29a
Copy link
Member

psi29a commented Oct 10, 2016

Feel free to add yourself to the list of contributors! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add property decorators in World

5 participants