Skip to content

Pre-validated ConnectionManager input#98

Merged
vik-rant merged 2 commits intodevfrom
feature/services/pre-validated-input
Jul 16, 2025
Merged

Pre-validated ConnectionManager input#98
vik-rant merged 2 commits intodevfrom
feature/services/pre-validated-input

Conversation

@christopherfish
Copy link
Contributor

Allow dynamic ConnectionManager methods to accept a single argument of the schema input type. That is, both of the following work:

from mindtrace.services.sample.echo_service import EchoInput, EchoService
echo_service_manager = EchoService.launch(url="http://localhost:8092", timeout=30)

result = echo_service_manager.echo(message="Integration test message")
assert result.echoed == "Integration test message"

input_message = EchoInput(message="Pre-validated test message")
result = echo_service_manager.echo(input_message)
assert result.echoed == "Pre-validated test message"

Tests should run and pass via uv sync; ds test and have 100% coverage in Services.

@christopherfish christopherfish self-assigned this Jul 16, 2025
@christopherfish christopherfish added the mindtrace-services Issues raised from services module in mindtrace package label Jul 16, 2025
@vik-rant vik-rant merged commit 9f196fd into dev Jul 16, 2025
2 of 4 checks passed
Yasserelhaddar pushed a commit that referenced this pull request Aug 26, 2025
…input

Pre-validated ConnectionManager input
@vik-rant vik-rant deleted the feature/services/pre-validated-input branch December 16, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mindtrace-services Issues raised from services module in mindtrace package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants