Conversation
JeremyWurbs
added
the
mindtrace-core
JeremyWurbs
requested changes
Jul 15, 2025
Contributor
JeremyWurbs
left a comment
JeremyWurbs
left a comment
There was a problem hiding this comment.
I like the MCP integration here.
I would be okay with it more or less as is once tests are added in. Perhaps we can think of an updated official list of endpoints to support, particularly making endpoint discovery match the same format for tool discovery, but that doesn't have to be in this initial PR.
| # Add the reverse_message tool directly (not as an endpoint) | ||
| self.add_tool("reverse_message", reverse_message) | ||
|
|
||
| def echo(self, payload: EchoInput) -> EchoOutput: |
Contributor
There was a problem hiding this comment.
I noticed the MCP pulls the docks from the class docstrings, so it might be good to make sure all of our classes / endpoint / tool methods have docstrings.
Collaborator
Author
There was a problem hiding this comment.
Agree, in the next PR, we can also have a warning to flag the functions with missing doc strings.
vik-rant
approved these changes
Jul 16, 2025
Yasserelhaddar
pushed a commit
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR enables both the FastAPI server and the FastMCP server to exist independently, while also providing a feature to mount the MCP app on the same FastAPI app if desired.
The changes are minimal and focused, making it easy to maintain separation or combine the two servers as needed.
Key Changes