fix: make local registry concurrent delete parent cleanup race-safe#376
Merged
JeremyWurbs merged 1 commit intodevfrom Feb 25, 2026
Merged
fix: make local registry concurrent delete parent cleanup race-safe#376JeremyWurbs merged 1 commit intodevfrom
JeremyWurbs merged 1 commit intodevfrom
Conversation
Handle FileNotFoundError when parent directory is removed concurrently during delete cleanup. Adds a focused unit test for the race path.
vik-rant
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition in local registry delete cleanup where
parent.iterdir()could raiseFileNotFoundErrorif another concurrent delete removed the parent directory between checks.Changes
LocalRegistryBackend.delete()parent-directory cleanup to be race-safe.FileNotFoundErrorduring parent cleanup as benign (already cleaned by another worker).Testing
uv run pytest tests/unit/mindtrace/registry/backends/test_local_registry_backend.py -k "delete_parent_cleanup_race_on_iterdir or delete_parent_directory_error"uv run pytest tests/integration/mindtrace/registry/core/test_all_supported_backends.py -k "test_concurrent_delete_operations and local"Fixes #375