Draft
Conversation
Collaborator
Author
|
Rollout update: pushed 2 additional unit-test commits focused on targeted low-coverage modules (especially hardware) with no production code changes. Included in this pass:
Validation run in this environment:
Notable remaining lower-coverage targeted files after this pass:
Coverage table in PR description has been refreshed for all targeted files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR contains only unit test changes (no production/library code changes), with targeted coverage improvements focused on low-coverage files, especially hardware.
Newly added/expanded tests in this update
tests/unit/mindtrace/hardware/cameras/homography/test_data.py(new)tests/unit/mindtrace/hardware/core/test_utils.py(new)tests/unit/mindtrace/hardware/sensors/backends/test_base.py(new)tests/unit/mindtrace/hardware/cameras/homography/test_calibration.pytests/unit/mindtrace/hardware/cameras/homography/test_measurement.pytests/unit/mindtrace/hardware/sensors/backends/test_mqtt.pytests/unit/mindtrace/hardware/sensors/services/test_connection_manager.pytests/unit/mindtrace/cluster/test_run_script_worker.pytests/unit/mindtrace/services/core/test_mcp_client_manager.pytests/unit/mindtrace/registry/core/test_registry_core_types.py(new)Highlights
types.pybehavior tests.Coverage (targeted files)
mindtrace/cluster/workers/run_script_worker.pymindtrace/hardware/cameras/homography/calibrator.pymindtrace/hardware/cameras/homography/data.pymindtrace/hardware/cameras/homography/measurer.pymindtrace/hardware/core/utils.pymindtrace/hardware/sensors/backends/base.pymindtrace/hardware/sensors/backends/mqtt.pymindtrace/hardware/services/sensors/connection_manager.pymindtrace/registry/core/types.pymindtrace/services/core/mcp_client_manager.pyValidation commands run
ruff check .(fails on existing baseline import-order issues in docker env tests/modules; unchanged by this update)ruff format --check .(fails on existing baseline formatting files; unchanged by this update)ds test --unit(same known baseline: 3 failed, 2 errors, docker-daemon-dependent tests)Notes
Test-count statistic (corrected)
def test_*) across 15 new test files (22 test files touched total).