Skip to content

Additional unit test pack#373

Draft
AgentDosaku wants to merge 6 commits intodevfrom
openclaw/20260225-012518-unit-test-coverage
Draft

Additional unit test pack#373
AgentDosaku wants to merge 6 commits intodevfrom
openclaw/20260225-012518-unit-test-coverage

Conversation

@AgentDosaku
Copy link
Collaborator

@AgentDosaku AgentDosaku commented Feb 25, 2026

What changed

This PR contains only unit test changes (no production/library code changes), with targeted coverage improvements focused on low-coverage files, especially hardware.

Newly added/expanded tests in this update

  • tests/unit/mindtrace/hardware/cameras/homography/test_data.py (new)
  • tests/unit/mindtrace/hardware/core/test_utils.py (new)
  • tests/unit/mindtrace/hardware/sensors/backends/test_base.py (new)
  • tests/unit/mindtrace/hardware/cameras/homography/test_calibration.py
  • tests/unit/mindtrace/hardware/cameras/homography/test_measurement.py
  • tests/unit/mindtrace/hardware/sensors/backends/test_mqtt.py
  • tests/unit/mindtrace/hardware/sensors/services/test_connection_manager.py
  • tests/unit/mindtrace/cluster/test_run_script_worker.py
  • tests/unit/mindtrace/services/core/test_mcp_client_manager.py
  • tests/unit/mindtrace/registry/core/test_registry_core_types.py (new)

Highlights

  • Added meaningful coverage for homography calibration/data/measuring flows (including multi-view path, serialization roundtrip, and distance APIs).
  • Added sensor backend base/mqtt/connection manager edge-path coverage.
  • Added run script worker Docker GCP-volume mapping coverage.
  • Added MCP descriptor behavior assertions and registry core types.py behavior tests.

Coverage (targeted files)

File Before After Delta
mindtrace/cluster/workers/run_script_worker.py 96.67% 100.00% +3.33%
mindtrace/hardware/cameras/homography/calibrator.py 65.71% 89.71% +24.00%
mindtrace/hardware/cameras/homography/data.py 50.00% 100.00% +50.00%
mindtrace/hardware/cameras/homography/measurer.py 80.82% 98.63% +17.81%
mindtrace/hardware/core/utils.py 77.78% 94.44% +16.66%
mindtrace/hardware/sensors/backends/base.py 73.33% 100.00% +26.67%
mindtrace/hardware/sensors/backends/mqtt.py 84.68% 94.59% +9.91%
mindtrace/hardware/services/sensors/connection_manager.py 97.22% 100.00% +2.78%
mindtrace/registry/core/types.py 83.55% 90.79% +7.24%
mindtrace/services/core/mcp_client_manager.py 95.00% 100.00% +5.00%

Validation commands run

  • ruff check . (fails on existing baseline import-order issues in docker env tests/modules; unchanged by this update)
  • ruff format --check . (fails on existing baseline formatting files; unchanged by this update)
  • ds test --unit (same known baseline: 3 failed, 2 errors, docker-daemon-dependent tests)

Notes

  • Existing unrelated baseline failures are unchanged in nature (Docker daemon unavailable in this environment).
  • No library code changes were made.

Test-count statistic (corrected)

  • Added 55 net new test cases (def test_*) across 15 new test files (22 test files touched total).

@AgentDosaku AgentDosaku marked this pull request as draft February 25, 2026 02:02
@AgentDosaku AgentDosaku requested a review from vik-rant February 25, 2026 02:11
@AgentDosaku
Copy link
Collaborator Author

AgentDosaku commented Feb 25, 2026

Rollout update: pushed 2 additional unit-test commits focused on targeted low-coverage modules (especially hardware) with no production code changes.

Included in this pass:

  • homography: calibrator/data/measurer expansions
  • sensors: backend base/mqtt + connection manager edge paths
  • core/cluster/registry: run_script_worker, mcp_client_manager, registry core types

Validation run in this environment:

  • ruff check . (baseline fails unchanged)
  • ruff format --check . (baseline fails unchanged)
  • ds test --unit (same known baseline: 3 failed, 2 errors; docker-daemon dependent)

Notable remaining lower-coverage targeted files after this pass:

  • registry/core/registry.py (70.61%)
  • services/core/launcher.py (75.51%)
  • registry/backends/s3_registry_backend.py (75.60%)
  • registry/backends/gcp_registry_backend.py (76.20%)
  • cluster/core/cluster.py (88.08%)

Coverage table in PR description has been refreshed for all targeted files.

@AgentDosaku AgentDosaku changed the title test: expand hardware unit test coverage across setup, stereo, and services Additional unit test pack Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant