Open
Conversation
…), match pop behaviour, simplify delete on registry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no normalization on version keys, i.e. "1" and "1.0.0" are treated as different versions, causing a subtle bug when object is saved with first version "1" but later explicit call used "1.0.0". We need to normalize such that they are equivalent internally and user can retrieve the same object either with 1.0.0 or 1 explicitly.
2 options:
1- pad to three parts. e.g. 1->1.0.0
2. strips trailing 0s. - "1.0.0" → "1", "1.1.0" → "1.1", "1.0.1" → unchanged
went with option 2, so that auto increment increments on the first non zero key. e.g. if 1.0.0 present-> next version is 2.
if 1.0.1 -> next version is 1.0.2.
Inputs like save(..., version="1.0.0") still work, normalization is internal
-> In outputs versions are normalized versions, we can maybe pad them back for display purposes or leave as it is.
extra:
if none given, delete all versions, if explicit version is given delete the explicit version or "latest" as a special key to delete the latest.