Fix: 177 Poseidon Enhancements#178
Open
uzairali19 wants to merge 3 commits into520-component-tablefrom
Open
Conversation
canelbirlik
reviewed
Sep 11, 2025
| @@ -0,0 +1,5 @@ | |||
| from poseidon.components_v2.core.button import button | |||
Contributor
There was a problem hiding this comment.
don't think we need to create a wrapper to just call these modern :D same with other components in forms/
Contributor
Author
There was a problem hiding this comment.
I just took the current code we had and put them in separate components, I know these are empty wrappers. I'll remove them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the user model and repository logic to simplify user identity, improve role handling, and enhance data consistency. The most significant changes include removing the
usernamefield, standardizing organization roles to strings, normalizing email addresses, and reorganizing repository methods for clarity and maintainability.User model and identity changes:
usernamefield from theUsermodel and all related code, relying solely onemailfor user identity. [1] [2]Data normalization and validation:
Repository API and logic improvements:
username,project_assignments, and multi-role lists), and grouped methods into clear "reads" and "writes" sections. [1] [2] [3]Role and relationship handling:
These changes streamline user management, improve reliability, and set the foundation for future enhancements.