You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added batch operations to google storage class utilizing those in the base class.
Added Model specific operations
The aim here was to easily be able to manage model & weights
RFC
Does it make sense to have all these extra functions in this GCStorageHandler class or should it only contain primitives and we make other classes for model registry + model specific operation (i.e. upload/download weights/configs).
I don't think extra domain specific functionality should be part of it and domains(like registry) should write services that use this adapter. My suggestion on how to break it:
layer1: GCS: Stays minimal defining infra ops,i.e. Infra adapter
layer2: TransferManager(Optional): integrity checks, deciding whether to download/upload something. Generic service, infra agnostic.
layer3: ModelRegistryService or RegistryService: implements versioning, task registration and rest of the tasks that require knowledge of what this domain is about.
If you think there won't be another service that needs integrity checks and deciding whether to download or skip some file, you could make transfer manager part of the registry service and skip that layer.
I agree that GCS should only be concerned with and offer primitives for handling storage ops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The aim here was to easily be able to manage model & weights
RFC
Does it make sense to have all these extra functions in this GCStorageHandler class or should it only contain primitives and we make other classes for model registry + model specific operation (i.e. upload/download weights/configs).
TO DOS
Add tests when all functionality is agreed upon