Skip to content

Extended GCS Functionality #172

Open
Joshua-Lister98 wants to merge 1 commit intodevfrom
feature/163-gcs-handler-expanded-functionality
Open

Extended GCS Functionality #172
Joshua-Lister98 wants to merge 1 commit intodevfrom
feature/163-gcs-handler-expanded-functionality

Conversation

@Joshua-Lister98
Copy link
Contributor

@Joshua-Lister98 Joshua-Lister98 commented Sep 1, 2025

Summary

  • Added model registry functions
  • Added batch operations to google storage class utilizing those in the base class.
  • Added Model specific operations

The aim here was to easily be able to manage model & weights

RFC

Does it make sense to have all these extra functions in this GCStorageHandler class or should it only contain primitives and we make other classes for model registry + model specific operation (i.e. upload/download weights/configs).

TO DOS

Add tests when all functionality is agreed upon

@Joshua-Lister98 Joshua-Lister98 self-assigned this Sep 1, 2025
@Joshua-Lister98 Joshua-Lister98 linked an issue Sep 1, 2025 that may be closed by this pull request
@Joshua-Lister98 Joshua-Lister98 force-pushed the feature/163-gcs-handler-expanded-functionality branch from ddf78cd to 82dc068 Compare September 1, 2025 14:06
@Joshua-Lister98 Joshua-Lister98 force-pushed the feature/163-gcs-handler-expanded-functionality branch from 82dc068 to 3b95f78 Compare September 1, 2025 14:17
@canelbirlik
Copy link
Contributor

canelbirlik commented Sep 2, 2025

I don't think extra domain specific functionality should be part of it and domains(like registry) should write services that use this adapter. My suggestion on how to break it:
layer1: GCS: Stays minimal defining infra ops,i.e. Infra adapter
layer2: TransferManager(Optional): integrity checks, deciding whether to download/upload something. Generic service, infra agnostic.
layer3: ModelRegistryService or RegistryService: implements versioning, task registration and rest of the tasks that require knowledge of what this domain is about.
If you think there won't be another service that needs integrity checks and deciding whether to download or skip some file, you could make transfer manager part of the registry service and skip that layer.

@vik-rant
Copy link
Contributor

vik-rant commented Sep 2, 2025

I agree that GCS should only be concerned with and offer primitives for handling storage ops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCS Handler Expanded Functionality

3 participants