Skip to content

feat: Attach context in breadcrumb custom data automatically #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

miquelbeltran
Copy link
Contributor

@miquelbeltran miquelbeltran commented Jun 20, 2024

feat: Attach context in breadcrumb custom data automatically

Description 📝

  • Purpose: Add breadcrumb that includes all AWS function Context automatically
  • Approach: Extend existing breadcrumb to add custom data.

As discussed in #20 this PR adds the functionality to attach relevant info to error report as breadcrumbs.

Type of change

  • New feature (non-breaking change which adds functionality)

Updates

  • Modify add breadcrumb call.
  • Improve tests.
  • Update example

Test plan 🧪

  • Unit tests.
  • Check end-to-end

Breadcrumb attached

image

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@miquelbeltran miquelbeltran requested review from a team, nikz, TheRealAgentK and PanosNB and removed request for a team June 20, 2024 07:15
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some problems getting the latest changes running in the example, so cleaning the node_modules ensures the code is properly refreshed.

Copy link

@sumitramanga sumitramanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍🏽

@miquelbeltran miquelbeltran merged commit 5f41266 into main Jul 10, 2024
10 checks passed
@miquelbeltran miquelbeltran deleted the add-context branch July 10, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants