Improve Genesis Ledger Creation #17641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of Mina_ledger.Ledger.t
glyh
force-pushed
the
lyh/improve-genesis-ledger-creation
branch
from
e63b32f to
f2470c6
Compare
Member
Author
|
!ci-build-me |
Member
Author
|
Just to be extra safe: |
Member
Author
|
!ci-nightly-me |
Member
|
!ci-bypass-changelog |
dannywillems
approved these changes
Aug 20, 2025
Member
dannywillems
left a comment
dannywillems
left a comment
There was a problem hiding this comment.
LGTM for crypto, only propagating.
cjjdespres
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR for https://www.notion.so/o1labs/Improve-genesis-epoch-ledger-snapshot-creation-23fe79b1f91080299e0edd9bd7a7e21a
I did it slightly different in that: in Genesis_epoch_ledger, store
Genesis_ledger.Packed.tinstead ofMina_ledger.Ledger.tThis would allow access to any function in
Genesis_ledger.Packed, withpopulate_rootincluded.Nightly: https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/3852
^ Seems to be passing