Build archive for each network #17457
Conversation
dkijania
changed the title
dkijania
force-pushed
the
dkijania/build_archive_for_each_network
branch
from
6087911 to
1333bd6
Compare
|
!ci-build-me |
1 similar comment
|
!ci-build-me |
dkijania
force-pushed
the
dkijania/build_archive_for_each_network
branch
from
7e039e4 to
f110df5
Compare
|
!ci-build-me |
1 similar comment
|
!ci-build-me |
|
!ci-nightly-me |
|
!ci-build-me |
|
!ci-build-me |
dkijania
changed the title
| # Add suffix to debian to distinguish different profiles (mainnet/devnet/lightnet) | ||
| case "${DUNE_PROFILE}" in | ||
| devnet|mainnet) |
There was a problem hiding this comment.
Is it normal it got removed?
There was a problem hiding this comment.
Yes, i simplified a logic here to add lightnet suffix to every network not only berkeley. That can be useful for future refactoring where we won't treat berkeley as special case network
dockerfiles/Dockerfile-mina-archive
Outdated
| @@ -15,7 +16,7 @@ ENV SUFFIX=${deb_suffix:+-${deb_suffix}} | |||
| # possible values: | |||
| # - mina-archive | |||
dannywillems
force-pushed
the
dkijania/build_archive_for_each_network
branch
from
724dee9 to
9446257
Compare
|
!ci-build-me |
1 similar comment
|
!ci-build-me |
dannywillems
force-pushed
the
dkijania/build_archive_for_each_network
branch
from
907bf5e to
889a210
Compare
| @@ -0,0 +1 @@ | |||
| Introduced one package for one network for archive artifact | |||
There was a problem hiding this comment.
| Introduced one package for one network for archive artifact | |
| Introduced a separate package per network for the archive artifact. |
| @@ -5,6 +5,7 @@ FROM ${image} | |||
| ARG deb_version | |||
| ARG deb_codename=bullseye | |||
| ARG deb_release=unstable | |||
| ARG network=mainnet | |||
There was a problem hiding this comment.
Could we have a target in the Makefile to build this docker image please?
| ##################################### ARCHIVE PACKAGE ########################################### | ||
| build_archive_deb () { | ||
| ARCHIVE_DEB=mina-archive${DEB_SUFFIX} | ||
| cp ./default/src/app/archive/archive.exe \ |
There was a problem hiding this comment.
Comment: using the same binary name in each Debian package means that we can only have one on each machine, otherwise it would be overwritten.
I guess it is the expected behavior.
There was a problem hiding this comment.
Yes. It was working like this for a long time. Nothing prevents us from changing that.
|
!ci-build-me |
We need replayer build with profile corresponding to network in order to fix chain receipt mismatch on mainnet. Complementary solution is to build archive debian and docker per network and profile. As a result we will replicate daemon variants (Berkeley,Devnet,Mainnet). Unfortunately we will increase number of dockers and debians. Fortunately, after we have another improvement on the list which moves auxiliary distros and artifacts to mainline nightly scope #17500