Push sig kind out of snark worker #17423
Conversation
| } | ||
|
|
||
| let create ~constraint_constants ~proof_level () = | ||
| let create ~constraint_constants ~proof_level ~signature_kind () = |
There was a problem hiding this comment.
Now we're tracking sig kind in the state of a snark worker.
|
!ci-build-me |
glyh
force-pushed
the
lyh/push-up-sig-kind-snark-worker
branch
from
bbb53a2 to
27f5d9e
Compare
There was a problem hiding this comment.
LGTM
A small follow-up for future work: it would be cool to make Snark worker configurationless, which means that Snark worker on the start would connect to Coordinator and request parameters for doing snark work. These parameters would include constraint constants, proof level, and signature kind. Probably doesn't make sense to have proof level there because why would you run a snark worker with non-full proof level.
All of the parameters on the snark worker would come from coordinator. Then we wouldn't need a separate configuration for the worker neither as CLI flag(s) or runtime config nor as compile time configuration.
|
!ci-build-me |
As title. Not much fancy here.