fix(settings): guard apply_filters call for early initialization#26
Open
fix(settings): guard apply_filters call for early initialization#26
Conversation
Allow get_default_settings() to be called before WordPress loads by checking if apply_filters() exists before using it. This enables Bedrock/Acorn projects to dynamically read MilliCache defaults in config/application.php without requiring hardcoded values.
Add defined() checks for DAY_IN_SECONDS and MONTH_IN_SECONDS to prevent errors when get_default_settings() is called before WordPress loads its constants (e.g., in Bedrock's application.php). Fallback values: 86400 (1 day), 2592000 (30 days)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_filters()call withfunction_exists()check inget_default_settings()config/application.php)Test plan
get_default_settings()from Bedrockapplication.php(before WordPress loads)