Skip to content

Comments

fix: previewLabel was always hidden#2192

Merged
Saul-Mirone merged 2 commits intoMilkdown:mainfrom
saidake:fix/missing-preview-label
Dec 8, 2025
Merged

fix: previewLabel was always hidden#2192
Saul-Mirone merged 2 commits intoMilkdown:mainfrom
saidake:fix/missing-preview-label

Conversation

@saidake
Copy link
Contributor

@saidake saidake commented Dec 6, 2025

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

This PR fixes an issue where the preview label was always hidden, even when preview mode was enabled.

How did you test this change?

Tested dependency update in my local pnpm workspace env.
image

@vercel
Copy link

vercel bot commented Dec 6, 2025

@saidake is attempting to deploy a commit to the Milkdown Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2025

⚠️ No Changeset found

Latest commit: 12e555b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saidake saidake force-pushed the fix/missing-preview-label branch from 0d96b3a to 0e79404 Compare December 6, 2025 23:54
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 6, 2025

Open in StackBlitz

@milkdown/components

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/components@2192

@milkdown/core

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/core@2192

@milkdown/crepe

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/crepe@2192

@milkdown/ctx

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/ctx@2192

@milkdown/exception

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/exception@2192

@milkdown/kit

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/kit@2192

@milkdown/prose

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/prose@2192

@milkdown/transformer

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/transformer@2192

@milkdown/utils

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/utils@2192

@milkdown/react

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/react@2192

@milkdown/vue

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/vue@2192

@milkdown/plugin-automd

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-automd@2192

@milkdown/plugin-block

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-block@2192

@milkdown/plugin-clipboard

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-clipboard@2192

@milkdown/plugin-collab

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-collab@2192

@milkdown/plugin-cursor

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-cursor@2192

@milkdown/plugin-emoji

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-emoji@2192

@milkdown/plugin-highlight

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-highlight@2192

@milkdown/plugin-history

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-history@2192

@milkdown/plugin-indent

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-indent@2192

@milkdown/plugin-listener

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-listener@2192

@milkdown/plugin-prism

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-prism@2192

@milkdown/plugin-slash

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-slash@2192

@milkdown/plugin-tooltip

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-tooltip@2192

@milkdown/plugin-trailing

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-trailing@2192

@milkdown/plugin-upload

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/plugin-upload@2192

@milkdown/preset-commonmark

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/preset-commonmark@2192

@milkdown/preset-gfm

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/preset-gfm@2192

@milkdown/theme-nord

npm i https://pkg.pr.new/Milkdown/milkdown/@milkdown/theme-nord@2192

commit: 12e555b

@Saul-Mirone Saul-Mirone added this pull request to the merge queue Dec 8, 2025
@Saul-Mirone
Copy link
Member

Nice catch.

Merged via the queue into Milkdown:main with commit 1145204 Dec 8, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants