feat: enable multiple files in the same yjs doc #1551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In current
plugin-collab
, the path to the XML fragment in the Yjs doc is hard-coded to'prosemirror'
, which makes it impossible to put multiple Milkdown documents in the same Yjs document.Since
y-prosemirror
has deprecatedyDocToProsemirror
foryXmlFragmentToProseMirrorRootNode
, I move fromY.Doc
& hard-coded path to user-providedY.XmlFragment
.How did you test this change?
Tested with storybook page.