Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable multiple files in the same yjs doc #1551

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zjkmxy
Copy link

@zjkmxy zjkmxy commented Nov 1, 2024

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

In current plugin-collab, the path to the XML fragment in the Yjs doc is hard-coded to 'prosemirror', which makes it impossible to put multiple Milkdown documents in the same Yjs document.
Since y-prosemirror has deprecated yDocToProsemirror for yXmlFragmentToProseMirrorRootNode, I move from Y.Doc & hard-coded path to user-provided Y.XmlFragment.

How did you test this change?

Tested with storybook page.

Copy link

changeset-bot bot commented Nov 1, 2024

⚠️ No Changeset found

Latest commit: bcea21f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 7:27pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant