fix: tooltip plugin offset (#1419)

* fix: tooltip plugin offset * chore: fix offset
Milkdown · Jul 11, 2024 · 615b697 · 615b697
1 parent 4511a04
commit 615b697
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/packages/crepe/src/feature/block-edit/menu/component.ts b/packages/crepe/src/feature/block-edit/menu/component.ts
@@ -62,11 +62,6 @@ export const menuComponent: Component<MenuProps> = ({
       return
 
     scrollRoot.scrollTop = target.offsetTop - scrollRoot.offsetTop
-
-    // target?.scrollIntoView({
-    //   behavior: 'smooth',
-    //   block: 'end',
-    // })
   }, [])
 
   const runByIndex = useCallback((index: number) => {

diff --git a/packages/crepe/src/feature/block-edit/menu/index.ts b/packages/crepe/src/feature/block-edit/menu/index.ts
@@ -70,6 +70,7 @@ class MenuView implements PluginView {
 
         return true
       },
+      offset: 10,
     })
 
     this.#slashProvider.onShow = () => {

diff --git a/packages/crepe/src/feature/toolbar/index.ts b/packages/crepe/src/feature/toolbar/index.ts
@@ -23,6 +23,7 @@ class ToolbarView implements PluginView {
     this.#tooltipProvider = new TooltipProvider({
       content: this.#content,
       debounce: 20,
+      offset: 10,
       shouldShow(view: EditorView) {
         const { doc, selection } = view.state
         const { empty, from, to } = selection

diff --git a/packages/plugins/plugin-tooltip/src/tooltip-provider.ts b/packages/plugins/plugin-tooltip/src/tooltip-provider.ts
@@ -84,7 +84,7 @@ export class TooltipProvider {
     }
     computePosition(virtualEl, this.element, {
       placement: 'top',
-      middleware: [flip()],
+      middleware: [flip(), offset(this.#offset)],
       platform: {
         ...platform,
         getOffsetParent: element =>