Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty sensor handling #15

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Conversation

frankysan
Copy link
Contributor

Added check for empty sensor

Copy link
Owner

@Miicroo Miicroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You can merge your other PR since it looks good too, and then I suspect that you will have "conflicts" between this branch and master that you will have to rebase (hence the "request change" reply here, nothing wrong with the PR itself) :)

@frankysan
Copy link
Contributor Author

Sure thing, just as soon as I figure it out :) Just learning GitHub here :)

@frankysan
Copy link
Contributor Author

I think I need to be added as contributor in order to merge, since I won't have write access otherwise.

@Miicroo Miicroo self-requested a review November 5, 2023 17:19
@Miicroo
Copy link
Owner

Miicroo commented Nov 5, 2023

I think I need to be added as contributor in order to merge, since I won't have write access otherwise.

Aha! I merged it since it was already ready! Can merge this one too, seems it doesn't have any conflicts

@Miicroo Miicroo merged commit b232e01 into Miicroo:master Nov 5, 2023
@frankysan frankysan deleted the Empty-sensor-handling branch November 5, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants