Skip to content

[JitDiff X64] [EgorBo] Mark some structs as byreflike #523

@MihuBot

Description

@MihuBot

Job completed in 14 minutes.
dotnet/runtime#104870

Diffs

Found 267 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 39113879
Total bytes of diff: 39113497
Total bytes of delta: -382 (-0.00 % of base)
Total relative delta: -6.52
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
        -321 : System.Private.CoreLib.dasm (-0.00 % of base)
         -26 : System.Security.Cryptography.dasm (-0.00 % of base)
         -15 : System.Text.RegularExpressions.dasm (-0.00 % of base)
         -11 : System.Net.NetworkInformation.dasm (-0.02 % of base)
          -9 : System.Reflection.Metadata.dasm (-0.00 % of base)

5 total files with Code Size differences (5 improved, 0 regressed), 254 unchanged.

Top method improvements (bytes):
         -41 (-77.36 % of base) : System.Private.CoreLib.dasm - System.Array+SorterGenericArray:.ctor(System.Array,System.Array,System.Collections.IComparer):this (FullOpts)
         -41 (-77.36 % of base) : System.Private.CoreLib.dasm - System.Array+SorterObjectArray:.ctor(System.Object[],System.Object[],System.Collections.IComparer):this (FullOpts)
         -36 (-7.07 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:ExpandPredefinedFormat(ushort,byref,byref,byref):System.String (FullOpts)
         -24 (-5.63 % of base) : System.Security.Cryptography.dasm - System.Security.Cryptography.XmlKeyHelper+ParseState:GetValue(System.String):System.String:this (FullOpts)
         -13 (-36.11 % of base) : System.Private.CoreLib.dasm - System.Net.WebUtility+UrlDecoder:.ctor(int,System.Text.Encoding):this (FullOpts)
         -11 (-5.61 % of base) : System.Net.NetworkInformation.dasm - System.Net.NetworkInformation.UnixIPGlobalProperties+Context:AddException(System.Exception):this (FullOpts)
         -10 (-35.71 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue:.ctor(System.Object):this (FullOpts)
         -10 (-27.03 % of base) : System.Private.CoreLib.dasm - System.ParsingInfo:.ctor(System.Globalization.Calendar):this (FullOpts)
         -10 (-38.46 % of base) : System.Private.CoreLib.dasm - System.TimeZoneInfo+StringSerializer:.ctor(System.String):this (FullOpts)
          -9 (-7.14 % of base) : System.Reflection.Metadata.dasm - System.Reflection.PortableExecutable.PEBinaryReader:.ctor(System.IO.Stream,int):this (FullOpts)
          -9 (-69.23 % of base) : System.Private.CoreLib.dasm - System.Threading.Volatile:Write[System.__Canon](byref,System.__Canon) (FullOpts)
          -8 (-5.52 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_2[System.__Canon]:<GetPropertyGetter>b__2(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-5.52 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_3[System.__Canon]:<GetPropertyGetter>b__3(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-5.52 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_4[System.__Canon]:<GetPropertyGetter>b__4(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-5.48 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_5[System.__Canon]:<GetPropertyGetter>b__5(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-5.48 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_6[System.__Canon]:<GetPropertyGetter>b__6(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-5.48 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_7[System.__Canon]:<GetPropertyGetter>b__7(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-5.52 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_8[System.__Canon]:<GetPropertyGetter>b__8(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-5.52 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_9[System.__Canon]:<GetPropertyGetter>b__9(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-9.20 % of base) : System.Private.CoreLib.dasm - System.Net.WebUtility+UrlDecoder:AddByte(ubyte):this (FullOpts)
          -8 (-7.55 % of base) : System.Private.CoreLib.dasm - System.Net.WebUtility+UrlDecoder:AddChar(ushort):this (FullOpts)
          -8 (-8.08 % of base) : System.Private.CoreLib.dasm - System.Net.WebUtility+UrlDecoder:FlushBytes():this (FullOpts)
          -6 (-4.58 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_0(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.58 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_1(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.48 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_12(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.58 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_2(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.55 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_3(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.55 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_4(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.55 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_5(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.62 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_6(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.62 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_7(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.14 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_14[System.__Canon]:<GetPropertyGetter>b__14(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -3 (-42.86 % of base) : System.Private.CoreLib.dasm - System.Reflection.NullabilityInfoContext+NullableAttributeStateParser:.ctor(System.Object):this (FullOpts)
          -3 (-21.43 % of base) : System.Text.RegularExpressions.dasm - System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+CurrentState[double]:.ctor(System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+NfaMatchingState[double]):this (FullOpts)
          -3 (-21.43 % of base) : System.Text.RegularExpressions.dasm - System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+CurrentState[int]:.ctor(System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+NfaMatchingState[int]):this (FullOpts)
          -3 (-21.43 % of base) : System.Text.RegularExpressions.dasm - System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+CurrentState[long]:.ctor(System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+NfaMatchingState[long]):this (FullOpts)
          -3 (-21.43 % of base) : System.Text.RegularExpressions.dasm - System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+CurrentState[short]:.ctor(System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+NfaMatchingState[short]):this (FullOpts)
          -3 (-21.43 % of base) : System.Text.RegularExpressions.dasm - System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+CurrentState[ubyte]:.ctor(System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+NfaMatchingState[ubyte]):this (FullOpts)
          -2 (-0.97 % of base) : System.Security.Cryptography.dasm - System.Security.Cryptography.XmlKeyHelper:ParseDocument(System.String):System.Security.Cryptography.XmlKeyHelper+ParseState (FullOpts)

Top method improvements (percentages):
         -41 (-77.36 % of base) : System.Private.CoreLib.dasm - System.Array+SorterGenericArray:.ctor(System.Array,System.Array,System.Collections.IComparer):this (FullOpts)
         -41 (-77.36 % of base) : System.Private.CoreLib.dasm - System.Array+SorterObjectArray:.ctor(System.Object[],System.Object[],System.Collections.IComparer):this (FullOpts)
          -9 (-69.23 % of base) : System.Private.CoreLib.dasm - System.Threading.Volatile:Write[System.__Canon](byref,System.__Canon) (FullOpts)
          -3 (-42.86 % of base) : System.Private.CoreLib.dasm - System.Reflection.NullabilityInfoContext+NullableAttributeStateParser:.ctor(System.Object):this (FullOpts)
         -10 (-38.46 % of base) : System.Private.CoreLib.dasm - System.TimeZoneInfo+StringSerializer:.ctor(System.String):this (FullOpts)
         -13 (-36.11 % of base) : System.Private.CoreLib.dasm - System.Net.WebUtility+UrlDecoder:.ctor(int,System.Text.Encoding):this (FullOpts)
         -10 (-35.71 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue:.ctor(System.Object):this (FullOpts)
         -10 (-27.03 % of base) : System.Private.CoreLib.dasm - System.ParsingInfo:.ctor(System.Globalization.Calendar):this (FullOpts)
          -3 (-21.43 % of base) : System.Text.RegularExpressions.dasm - System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+CurrentState[double]:.ctor(System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+NfaMatchingState[double]):this (FullOpts)
          -3 (-21.43 % of base) : System.Text.RegularExpressions.dasm - System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+CurrentState[int]:.ctor(System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+NfaMatchingState[int]):this (FullOpts)
          -3 (-21.43 % of base) : System.Text.RegularExpressions.dasm - System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+CurrentState[long]:.ctor(System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+NfaMatchingState[long]):this (FullOpts)
          -3 (-21.43 % of base) : System.Text.RegularExpressions.dasm - System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+CurrentState[short]:.ctor(System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+NfaMatchingState[short]):this (FullOpts)
          -3 (-21.43 % of base) : System.Text.RegularExpressions.dasm - System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+CurrentState[ubyte]:.ctor(System.Text.RegularExpressions.Symbolic.SymbolicRegexMatcher`1+NfaMatchingState[ubyte]):this (FullOpts)
          -8 (-9.20 % of base) : System.Private.CoreLib.dasm - System.Net.WebUtility+UrlDecoder:AddByte(ubyte):this (FullOpts)
          -8 (-8.08 % of base) : System.Private.CoreLib.dasm - System.Net.WebUtility+UrlDecoder:FlushBytes():this (FullOpts)
          -8 (-7.55 % of base) : System.Private.CoreLib.dasm - System.Net.WebUtility+UrlDecoder:AddChar(ushort):this (FullOpts)
          -9 (-7.14 % of base) : System.Reflection.Metadata.dasm - System.Reflection.PortableExecutable.PEBinaryReader:.ctor(System.IO.Stream,int):this (FullOpts)
         -36 (-7.07 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:ExpandPredefinedFormat(ushort,byref,byref,byref):System.String (FullOpts)
         -24 (-5.63 % of base) : System.Security.Cryptography.dasm - System.Security.Cryptography.XmlKeyHelper+ParseState:GetValue(System.String):System.String:this (FullOpts)
         -11 (-5.61 % of base) : System.Net.NetworkInformation.dasm - System.Net.NetworkInformation.UnixIPGlobalProperties+Context:AddException(System.Exception):this (FullOpts)
          -8 (-5.52 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_2[System.__Canon]:<GetPropertyGetter>b__2(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-5.52 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_3[System.__Canon]:<GetPropertyGetter>b__3(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-5.52 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_4[System.__Canon]:<GetPropertyGetter>b__4(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-5.52 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_8[System.__Canon]:<GetPropertyGetter>b__8(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-5.52 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_9[System.__Canon]:<GetPropertyGetter>b__9(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-5.48 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_5[System.__Canon]:<GetPropertyGetter>b__5(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-5.48 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_6[System.__Canon]:<GetPropertyGetter>b__6(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -8 (-5.48 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_7[System.__Canon]:<GetPropertyGetter>b__7(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.62 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_6(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.62 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_7(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.58 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_0(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.58 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_1(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.58 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_2(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.55 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_3(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.55 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_4(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.55 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_5(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.48 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+<>c:<GetFactory>b__25_12(System.Object):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -6 (-4.14 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.PropertyValue+ReferenceTypeHelper`1+<>c__DisplayClass1_14[System.__Canon]:<GetPropertyGetter>b__14(System.Diagnostics.Tracing.PropertyValue):System.Diagnostics.Tracing.PropertyValue:this (FullOpts)
          -2 (-0.97 % of base) : System.Security.Cryptography.dasm - System.Security.Cryptography.XmlKeyHelper:ParseDocument(System.String):System.Security.Cryptography.XmlKeyHelper+ParseState (FullOpts)

39 total methods with Code Size differences (39 improved, 0 regressed), 230439 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions