Skip to content

[X64] [MihaZupan] Add SearchValues<char> implementation for two sets of 128 chars #464

Open
@MihuBot

Description

@MihuBot

Job completed in 14 minutes.
dotnet/runtime#103216

Diffs

Found 268 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 41550967
Total bytes of diff: 41552691
Total bytes of delta: 1724 (0.00 % of base)
Total relative delta: 0.14
    diff is a regression.
    relative diff is a regression.


Total byte diff includes 1523 bytes from reconciling methods
	Base had    0 unique methods,        0 unique bytes
	Diff had    8 unique methods,     1523 unique bytes

Top file regressions (bytes):
        1723 : System.Private.CoreLib.dasm (0.02 % of base)
           1 : System.Private.Uri.dasm (0.00 % of base)

2 total files with Code Size differences (0 improved, 2 regressed), 256 unchanged.

Top method regressions (bytes):
         654 (Infinity of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher:TryComputeAsciiWithSecondSetState(System.ReadOnlySpan`1[ushort],int,byref):ubyte (FullOpts) (0 base, 1 diff methods)
         632 (Infinity of base) : System.Private.CoreLib.dasm - System.SpanHelpers:NonPackedIndexOfAnyInRangeUnsignedNumber[ushort,System.SpanHelpers+DontNegate`1[ushort]](byref,ushort,ushort,int):int (FullOpts) (0 base, 1 diff methods)
         185 (9.60 % of base) : System.Private.CoreLib.dasm - System.Buffers.SearchValues:Create(System.ReadOnlySpan`1[ushort]):System.Buffers.SearchValues`1[ushort] (FullOpts)
         144 (Infinity of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher+AsciiWithSecondSetState:.ctor(System.Runtime.Intrinsics.Vector128`1[ubyte],ushort,System.Runtime.Intrinsics.Vector128`1[ubyte],System.Buffers.ProbabilisticMapState):this (FullOpts) (0 base, 1 diff methods)
          29 (Infinity of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher:SetBitmapBit(ulong,int) (FullOpts) (0 base, 1 diff methods)
          19 (Infinity of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher+AsciiWithSecondSetState:SecondBitmap256():System.Runtime.Intrinsics.Vector256`1[ubyte]:this (FullOpts) (0 base, 1 diff methods)
          16 (Infinity of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher+AsciiWithSecondSetState:AsciiBitmap256():System.Runtime.Intrinsics.Vector256`1[ubyte]:this (FullOpts) (0 base, 1 diff methods)
          16 (Infinity of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher+AsciiWithSecondSetState:SecondBitmap128():System.Runtime.Intrinsics.Vector128`1[ubyte]:this (FullOpts) (0 base, 1 diff methods)
          15 (3.78 % of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher:ComputeAnyByteState(System.ReadOnlySpan`1[ubyte],byref) (FullOpts)
          13 (Infinity of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher+AsciiWithSecondSetState:AsciiBitmap128():System.Runtime.Intrinsics.Vector128`1[ubyte]:this (FullOpts) (0 base, 1 diff methods)
           1 (0.16 % of base) : System.Private.Uri.dasm - System.DomainNameHelper:IsValid(System.ReadOnlySpan`1[ushort],ubyte,ubyte,byref):ubyte (FullOpts)

Top method regressions (percentages):
          29 (Infinity of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher:SetBitmapBit(ulong,int) (FullOpts) (0 base, 1 diff methods)
         654 (Infinity of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher:TryComputeAsciiWithSecondSetState(System.ReadOnlySpan`1[ushort],int,byref):ubyte (FullOpts) (0 base, 1 diff methods)
         144 (Infinity of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher+AsciiWithSecondSetState:.ctor(System.Runtime.Intrinsics.Vector128`1[ubyte],ushort,System.Runtime.Intrinsics.Vector128`1[ubyte],System.Buffers.ProbabilisticMapState):this (FullOpts) (0 base, 1 diff methods)
          13 (Infinity of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher+AsciiWithSecondSetState:AsciiBitmap128():System.Runtime.Intrinsics.Vector128`1[ubyte]:this (FullOpts) (0 base, 1 diff methods)
          16 (Infinity of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher+AsciiWithSecondSetState:AsciiBitmap256():System.Runtime.Intrinsics.Vector256`1[ubyte]:this (FullOpts) (0 base, 1 diff methods)
          16 (Infinity of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher+AsciiWithSecondSetState:SecondBitmap128():System.Runtime.Intrinsics.Vector128`1[ubyte]:this (FullOpts) (0 base, 1 diff methods)
          19 (Infinity of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher+AsciiWithSecondSetState:SecondBitmap256():System.Runtime.Intrinsics.Vector256`1[ubyte]:this (FullOpts) (0 base, 1 diff methods)
         632 (Infinity of base) : System.Private.CoreLib.dasm - System.SpanHelpers:NonPackedIndexOfAnyInRangeUnsignedNumber[ushort,System.SpanHelpers+DontNegate`1[ushort]](byref,ushort,ushort,int):int (FullOpts) (0 base, 1 diff methods)
         185 (9.60 % of base) : System.Private.CoreLib.dasm - System.Buffers.SearchValues:Create(System.ReadOnlySpan`1[ushort]):System.Buffers.SearchValues`1[ushort] (FullOpts)
          15 (3.78 % of base) : System.Private.CoreLib.dasm - System.Buffers.IndexOfAnyAsciiSearcher:ComputeAnyByteState(System.ReadOnlySpan`1[ubyte],byref) (FullOpts)
           1 (0.16 % of base) : System.Private.Uri.dasm - System.DomainNameHelper:IsValid(System.ReadOnlySpan`1[ushort],ubyte,ubyte,byref):ubyte (FullOpts)

11 total methods with Code Size differences (0 improved, 11 regressed), 252026 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions