Skip to content

[JitDiff X64] [EgorBo] Remove unsafe from DateTimeRawInfo #1623

@MihuBot

Description

@MihuBot

Job completed in 17 minutes 2 seconds (remote runner delay: 46 seconds).
dotnet/runtime#121479

Diffs

Diffs
Found 84 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 45924561
Total bytes of diff: 45923260
Total bytes of delta: -1301 (-0.00 % of base)
Total relative delta: 2.64
    diff is an improvement.
    relative diff is a regression.


Total byte diff includes -1161 bytes from reconciling methods
	Base had    6 unique methods,     5482 unique bytes
	Diff had    7 unique methods,     4321 unique bytes

Top file improvements (bytes):
       -1301 : System.Private.CoreLib.dasm (-0.02 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 259 unchanged.

Top method regressions (bytes):
        3092 (Infinity of base) : System.Private.CoreLib.dasm - System.DateTimeParse:Lex(byte,byref,byref,byref,byref,byref,int):bool (FullOpts) (0 base, 1 diff methods)
         601 (Infinity of base) : System.Private.CoreLib.dasm - System.DateTimeParse:ProcessHebrewTerminalState(byte,byref,byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts) (0 base, 1 diff methods)
         459 (Infinity of base) : System.Private.CoreLib.dasm - System.DateTimeParse:ProcessTerminalState(byte,byref,byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts) (0 base, 1 diff methods)
          64 (Infinity of base) : System.Private.CoreLib.dasm - System.DateTimeParse:AdjustHour(byref,sbyte):bool (FullOpts) (0 base, 1 diff methods)
          46 (Infinity of base) : System.Private.CoreLib.dasm - System.DateTimeRawInfo:Init():this (FullOpts) (0 base, 1 diff methods)
          43 (Infinity of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetParsingState(byte,int):byte (FullOpts) (0 base, 1 diff methods)
          19 (190.00 % of base) : System.Private.CoreLib.dasm - System.DateTimeRawInfo:GetNumber(int):int:this (FullOpts)
          16 (Infinity of base) : System.Private.CoreLib.dasm - System.DateTimeParse:get_DateParsingStates():System.ReadOnlySpan`1[byte] (FullOpts) (0 base, 1 diff methods)
          14 (73.68 % of base) : System.Private.CoreLib.dasm - System.DateTimeRawInfo:AddNumber(int):this (FullOpts)
          12 (2.07 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDateOfNNDS(byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           7 (1.04 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfNNN(byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           5 (0.11 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:ParseByFormat(byref,byref,byref,System.Globalization.DateTimeFormatInfo,byref):bool (FullOpts)
           4 (1.29 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfNN(byref,byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           4 (0.99 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfNNY(byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           4 (1.31 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfYNN(byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           4 (1.95 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetHebrewDayOfNM(byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           3 (1.45 % of base) : System.Private.CoreLib.dasm - System.__DTString:GetSubString():System.DTSubString:this (FullOpts)
           3 (0.26 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:ParseISO8601(byref,byref,int,byref):bool (FullOpts)
           2 (0.38 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfMN(byref,byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           2 (0.23 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfMNN(byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           2 (0.38 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfNM(byref,byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           1 (2.38 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDateOfDSN(byref,byref):bool (FullOpts)
           1 (1.16 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDateOfNDS(byref,byref):bool (FullOpts)
           1 (0.83 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfYMN(byref,byref):bool (FullOpts)
           1 (0.81 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfYN(byref,byref):bool (FullOpts)
           1 (2.04 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetTimeOfN(byref,byref):bool (FullOpts)
           1 (2.17 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetTimeOfNN(byref,byref):bool (FullOpts)
           1 (1.82 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetTimeOfNNN(byref,byref):bool (FullOpts)

Top method improvements (bytes):
       -3047 (-100.00 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:Lex(int,byref,byref,byref,byref,byref,int):bool (FullOpts) (1 base, 0 diff methods)
       -1267 (-100.00 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:.cctor() (FullOpts) (1 base, 0 diff methods)
        -599 (-100.00 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:ProcessHebrewTerminalState(int,byref,byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts) (1 base, 0 diff methods)
        -456 (-100.00 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:ProcessTerminalState(int,byref,byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts) (1 base, 0 diff methods)
        -206 (-10.82 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:TryParse(System.ReadOnlySpan`1[char],System.Globalization.DateTimeFormatInfo,int,byref):bool (FullOpts) (2 methods)
         -60 (-100.00 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:AdjustHour(byref,int):bool (FullOpts) (1 base, 0 diff methods)
         -53 (-100.00 % of base) : System.Private.CoreLib.dasm - System.DateTimeRawInfo:Init(ptr):this (FullOpts) (1 base, 0 diff methods)
         -11 (-1.52 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:MatchTimeMark(byref,System.Globalization.DateTimeFormatInfo,byref):bool (FullOpts)
          -4 (-0.68 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:AdjustTimeMark(System.Globalization.DateTimeFormatInfo,byref) (FullOpts)
          -4 (-0.23 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:DoStrictParse(System.ReadOnlySpan`1[char],System.ReadOnlySpan`1[char],int,System.Globalization.DateTimeFormatInfo,byref):bool (FullOpts)
          -4 (-1.05 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:MatchAbbreviatedTimeMark(byref,System.Globalization.DateTimeFormatInfo,byref):bool (FullOpts)
          -3 (-8.11 % of base) : System.Private.CoreLib.dasm - System.ParsingInfo:.ctor(System.Globalization.Calendar):this (FullOpts)

Top method regressions (percentages):
          64 (Infinity of base) : System.Private.CoreLib.dasm - System.DateTimeParse:AdjustHour(byref,sbyte):bool (FullOpts) (0 base, 1 diff methods)
          16 (Infinity of base) : System.Private.CoreLib.dasm - System.DateTimeParse:get_DateParsingStates():System.ReadOnlySpan`1[byte] (FullOpts) (0 base, 1 diff methods)
          43 (Infinity of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetParsingState(byte,int):byte (FullOpts) (0 base, 1 diff methods)
        3092 (Infinity of base) : System.Private.CoreLib.dasm - System.DateTimeParse:Lex(byte,byref,byref,byref,byref,byref,int):bool (FullOpts) (0 base, 1 diff methods)
         601 (Infinity of base) : System.Private.CoreLib.dasm - System.DateTimeParse:ProcessHebrewTerminalState(byte,byref,byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts) (0 base, 1 diff methods)
         459 (Infinity of base) : System.Private.CoreLib.dasm - System.DateTimeParse:ProcessTerminalState(byte,byref,byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts) (0 base, 1 diff methods)
          46 (Infinity of base) : System.Private.CoreLib.dasm - System.DateTimeRawInfo:Init():this (FullOpts) (0 base, 1 diff methods)
          19 (190.00 % of base) : System.Private.CoreLib.dasm - System.DateTimeRawInfo:GetNumber(int):int:this (FullOpts)
          14 (73.68 % of base) : System.Private.CoreLib.dasm - System.DateTimeRawInfo:AddNumber(int):this (FullOpts)
           1 (2.38 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDateOfDSN(byref,byref):bool (FullOpts)
           1 (2.17 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetTimeOfNN(byref,byref):bool (FullOpts)
          12 (2.07 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDateOfNNDS(byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           1 (2.04 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetTimeOfN(byref,byref):bool (FullOpts)
           4 (1.95 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetHebrewDayOfNM(byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           1 (1.82 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetTimeOfNNN(byref,byref):bool (FullOpts)
           3 (1.45 % of base) : System.Private.CoreLib.dasm - System.__DTString:GetSubString():System.DTSubString:this (FullOpts)
           4 (1.31 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfYNN(byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           4 (1.29 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfNN(byref,byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           1 (1.16 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDateOfNDS(byref,byref):bool (FullOpts)
           7 (1.04 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfNNN(byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           4 (0.99 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfNNY(byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           1 (0.83 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfYMN(byref,byref):bool (FullOpts)
           1 (0.81 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfYN(byref,byref):bool (FullOpts)
           2 (0.38 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfMN(byref,byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           2 (0.38 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfNM(byref,byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           3 (0.26 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:ParseISO8601(byref,byref,int,byref):bool (FullOpts)
           2 (0.23 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:GetDayOfMNN(byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts)
           5 (0.11 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:ParseByFormat(byref,byref,byref,System.Globalization.DateTimeFormatInfo,byref):bool (FullOpts)

Top method improvements (percentages):
       -1267 (-100.00 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:.cctor() (FullOpts) (1 base, 0 diff methods)
         -60 (-100.00 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:AdjustHour(byref,int):bool (FullOpts) (1 base, 0 diff methods)
       -3047 (-100.00 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:Lex(int,byref,byref,byref,byref,byref,int):bool (FullOpts) (1 base, 0 diff methods)
        -599 (-100.00 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:ProcessHebrewTerminalState(int,byref,byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts) (1 base, 0 diff methods)
        -456 (-100.00 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:ProcessTerminalState(int,byref,byref,byref,System.Globalization.DateTimeFormatInfo):bool (FullOpts) (1 base, 0 diff methods)
         -53 (-100.00 % of base) : System.Private.CoreLib.dasm - System.DateTimeRawInfo:Init(ptr):this (FullOpts) (1 base, 0 diff methods)
        -206 (-10.82 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:TryParse(System.ReadOnlySpan`1[char],System.Globalization.DateTimeFormatInfo,int,byref):bool (FullOpts) (2 methods)
          -3 (-8.11 % of base) : System.Private.CoreLib.dasm - System.ParsingInfo:.ctor(System.Globalization.Calendar):this (FullOpts)
         -11 (-1.52 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:MatchTimeMark(byref,System.Globalization.DateTimeFormatInfo,byref):bool (FullOpts)
          -4 (-1.05 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:MatchAbbreviatedTimeMark(byref,System.Globalization.DateTimeFormatInfo,byref):bool (FullOpts)
          -4 (-0.68 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:AdjustTimeMark(System.Globalization.DateTimeFormatInfo,byref) (FullOpts)
          -4 (-0.23 % of base) : System.Private.CoreLib.dasm - System.DateTimeParse:DoStrictParse(System.ReadOnlySpan`1[char],System.ReadOnlySpan`1[char],int,System.Globalization.DateTimeFormatInfo,byref):bool (FullOpts)

40 total methods with Code Size differences (12 improved, 28 regressed), 282966 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions