[JitDiff X64] [xtqqczze] Use DateTime.MaxTicks instead of DateTime.MaxValue. ...

[MihuBot]

Job completed in 16 minutes 36 seconds (remote runner delay: 44 seconds).
dotnet/runtime#121091

Diffs

Found 83 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46023744
Total bytes of diff: 46023757
Total bytes of delta: 13 (0.00 % of base)
Total relative delta: 0.12
    diff is a regression.
    relative diff is a regression.


Top file regressions (bytes):
          13 : System.Private.CoreLib.dasm (0.00 % of base)

1 total files with Code Size differences (0 improved, 1 regressed), 259 unchanged.

Top method regressions (bytes):
          13 (11.50 % of base) : System.Private.CoreLib.dasm - System.Globalization.CalendricalCalculationsHelper:GetGregorianYear(double):int (FullOpts)

Top method regressions (percentages):
          13 (11.50 % of base) : System.Private.CoreLib.dasm - System.Globalization.CalendricalCalculationsHelper:GetGregorianYear(double):int (FullOpts)

1 total methods with Code Size differences (0 improved, 1 regressed), 282895 unchanged.

--------------------------------------------------------------------------------

Artifacts:

• build-clr-checked-main.zip (87 MB)
• build-artifacts-main.zip (678 MB)
• build-clr-checked-pr.zip (87 MB)
• build-artifacts-pr.zip (679 MB)
• jit-diffs-pr.zip (154 MB)
• jit-diffs-main.zip (154 MB)
• diff-frameworks.txt (999 B)
• ShortDiffsRegressions.md (4 KB)

[MihuBot]

Top method regressions

13 (11.50 % of base) - System.Globalization.CalendricalCalculationsHelper:GetGregorianYear(double):int

 ; Assembly listing for method System.Globalization.CalendricalCalculationsHelper:GetGregorianYear(double):int (FullOpts)
 ; Emitting BLENDED_CODE for generic X64 + VEX + EVEX on Unix
 ; FullOpts code
 ; optimized code
-; rsp based frame
+; rbp based frame
 ; fully interruptible
 ; No PGO data
-; 0 inlinees with PGO data; 2 single block inlinees; 2 inlinees without PGO data
+; 0 inlinees with PGO data; 1 single block inlinees; 2 inlinees without PGO data
 ; Final local variable assignments
 ;
-;  V00 arg0         [V00,T04] (  3,  3   )  double  ->  mm0         single-def
+;  V00 arg0         [V00,T03] (  3,  3   )  double  ->  mm0         single-def
 ;* V01 loc0         [V01    ] (  0,  0   )  struct ( 8) zero-ref    ld-addr-op <System.DateTime>
 ;# V02 OutArgs      [V02    ] (  1,  1   )  struct ( 0) [rsp+0x00]  do-not-enreg[XS] addr-exposed "OutgoingArgSpace" <Empty>
 ;* V03 tmp1         [V03    ] (  0,  0   )  struct ( 8) zero-ref    ld-addr-op "NewObj constructor temp" <System.DateTime>
-;  V04 tmp2         [V04,T01] (  3,  3   )    long  ->  rdi         "Inline return value spill temp"
-;  V05 tmp3         [V05,T00] (  3,  6   )    long  ->  rdi         "Inlining Arg"
-;* V06 tmp4         [V06,T02] (  0,  0   )    long  ->  zero-ref    "Inlining Arg"
-;* V07 tmp5         [V07    ] (  0,  0   )    long  ->  zero-ref    "field V01._dateData (fldOffset=0x0)" P-INDEP
-;* V08 tmp6         [V08    ] (  0,  0   )    long  ->  zero-ref    "field V03._dateData (fldOffset=0x0)" P-INDEP
-;  V09 rat0         [V09,T03] (  5, 10   )  simd16  ->  mm0         "ReplaceWithLclVar is creating a new local variable"
+;  V04 tmp2         [V04,T01] (  4,  2.50)    long  ->  rdi         "Inline return value spill temp"
+;  V05 tmp3         [V05,T00] (  3,  5   )    long  ->  rdi         "Inlining Arg"
+;* V06 tmp4         [V06    ] (  0,  0   )    long  ->  zero-ref    "field V01._dateData (fldOffset=0x0)" P-INDEP
+;* V07 tmp5         [V07    ] (  0,  0   )    long  ->  zero-ref    "field V03._dateData (fldOffset=0x0)" P-INDEP
+;  V08 rat0         [V08,T02] (  5, 10   )  simd16  ->  mm0         "ReplaceWithLclVar is creating a new local variable"
 ;
-; Lcl frame size = 8
+; Lcl frame size = 0
 
 G_M32864_IG01:
-       push     rax
-						;; size=1 bbWeight=1 PerfScore 1.00
+       push     rbp
+       mov      rbp, rsp
+						;; size=4 bbWeight=1 PerfScore 1.25
 G_M32864_IG02:
        vroundsd xmm0, xmm0, xmm0, 9
        vmulsd   xmm0, xmm0, qword ptr [reloc @RWD00]
        vcmpordsd xmm1, xmm0, xmm0
        vandpd   xmm1, xmm1, xmm0
-       mov      rdi, 0xD1FFAB1E
-       vcvttsd2si rax, xmm1
-       vucomisd xmm0, qword ptr [reloc @RWD08]
-       cmovb    rdi, rax
        mov      rax, 0xD1FFAB1E
-       mov      rcx, 0xD1FFAB1E
+       vcvttsd2si rcx, xmm1
+       vucomisd xmm0, qword ptr [reloc @RWD08]
+       cmovb    rax, rcx
+       mov      rdi, rax
+       mov      rax, 0xD1FFAB1E
        cmp      rdi, rax
-       cmovg    rdi, rcx
-       cmp      rdi, rax
-       ja       SHORT G_M32864_IG04
-       mov      rax, 0xD1FFAB1E      ; code for System.DateTime:GetYear(ulong):int
-						;; size=92 bbWeight=1 PerfScore 28.33
+       jg       SHORT G_M32864_IG04
+						;; size=68 bbWeight=1 PerfScore 27.58
 G_M32864_IG03:
-       add      rsp, 8
-       tail.jmp [rax]System.DateTime:GetYear(ulong):int
-						;; size=7 bbWeight=1 PerfScore 4.25
+       mov      rax, 0xD1FFAB1E
+       cmp      rdi, rax
+       jbe      SHORT G_M32864_IG05
+       jmp      SHORT G_M32864_IG07
+						;; size=17 bbWeight=0.50 PerfScore 1.75
 G_M32864_IG04:
+       mov      rdi, 0xD1FFAB1E
+						;; size=10 bbWeight=0.50 PerfScore 0.12
+G_M32864_IG05:
+       mov      rax, 0xD1FFAB1E      ; code for System.DateTime:GetYear(ulong):int
+						;; size=10 bbWeight=1 PerfScore 0.25
+G_M32864_IG06:
+       pop      rbp
+       tail.jmp [rax]System.DateTime:GetYear(ulong):int
+						;; size=4 bbWeight=1 PerfScore 4.50
+G_M32864_IG07:
        mov      rax, 0xD1FFAB1E      ; code for System.DateTime:ThrowTicksOutOfRange()
        call     [rax]System.DateTime:ThrowTicksOutOfRange()
        int3     
 						;; size=13 bbWeight=0 PerfScore 0.00
 RWD00  	dq	4269254D38000000h	;     8.64e+11
 RWD08  	dq	43E0000000000000h
 
 
-; Total bytes of code 113, prolog size 1, PerfScore 33.58, instruction count 21, allocated bytes for code 113 (MethodHash=62df7f9f) for method System.Globalization.CalendricalCalculationsHelper:GetGregorianYear(double):int (FullOpts)
+; Total bytes of code 126, prolog size 4, PerfScore 35.46, instruction count 25, allocated bytes for code 126 (MethodHash=62df7f9f) for method System.Globalization.CalendricalCalculationsHelper:GetGregorianYear(double):int (FullOpts)
 ; ============================================================

[MihuBot]

@xtqqczze