Skip to content

[JitDiff X64] [xtqqczze] Normalize Array.IndexOf result checks to use >= 0 #1526

@MihuBot

Description

@MihuBot

Job completed in 17 minutes 30 seconds (remote runner delay: 33 seconds).
dotnet/runtime#119936

Diffs

Found 92 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 41728031
Total bytes of diff: 41727979
Total bytes of delta: -52 (-0.00 % of base)
Total relative delta: -0.47
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
         -32 : System.Collections.dasm (-0.01 % of base)
          -5 : System.IO.Packaging.dasm (-0.00 % of base)
          -4 : System.Net.Security.dasm (-0.00 % of base)
          -4 : System.Text.Json.dasm (-0.00 % of base)
          -2 : System.Net.WebProxy.dasm (-0.04 % of base)
          -1 : System.ComponentModel.TypeConverter.dasm (-0.00 % of base)
          -1 : System.Net.Http.dasm (-0.00 % of base)
          -1 : System.Formats.Asn1.dasm (-0.00 % of base)
          -1 : System.Private.CoreLib.dasm (-0.00 % of base)
          -1 : System.Net.NameResolution.dasm (-0.00 % of base)

10 total files with Code Size differences (10 improved, 0 regressed), 250 unchanged.

Top method improvements (bytes):
          -4 (-4.82 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[byte]:Contains(byte):bool:this (FullOpts)
          -4 (-5.06 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[double]:Contains(double):bool:this (FullOpts)
          -4 (-5.06 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[int]:Contains(int):bool:this (FullOpts)
          -4 (-5.06 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[long]:Contains(long):bool:this (FullOpts)
          -4 (-4.82 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[short]:Contains(short):bool:this (FullOpts)
          -4 (-1.65 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[System.__Canon]:Contains(System.__Canon):bool:this (FullOpts)
          -4 (-3.85 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[System.Nullable`1[int]]:Contains(System.Nullable`1[int]):bool:this (FullOpts)
          -4 (-3.88 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[System.Numerics.Vector`1[float]]:Contains(System.Numerics.Vector`1[float]):bool:this (FullOpts)
          -4 (-6.78 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.ContentType:IsLinearWhiteSpaceChar(char):bool (FullOpts)
          -4 (-0.10 % of base) : System.Net.Security.dasm - System.Net.Security.SslStream:SelectClientCertificate():System.Security.Cryptography.X509Certificates.X509Certificate2:this (FullOpts)
          -4 (-4.35 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.IgnoreReferenceResolver:ContainsReferenceForCycleDetection(System.Object):bool:this (FullOpts)
          -2 (-0.39 % of base) : System.Net.WebProxy.dasm - System.Net.WebProxy:IsLocal(System.Uri):bool (FullOpts)
          -1 (-0.24 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.CultureInfoConverter:GetStandardValues(System.ComponentModel.ITypeDescriptorContext):System.ComponentModel.TypeConverter+StandardValuesCollection:this (FullOpts)
          -1 (-0.19 % of base) : System.Formats.Asn1.dasm - System.Formats.Asn1.AsnWriter+Scope:Dispose():this (FullOpts)
          -1 (-0.04 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.PartBasedPackageProperties:ParseCorePropertyPart(System.IO.Packaging.PackagePart):this (FullOpts)
          -1 (-0.27 % of base) : System.Net.Http.dasm - System.Net.Http.Headers.ObjectCollection`1[System.__Canon]:Remove(System.__Canon):bool:this (FullOpts)
          -1 (-0.11 % of base) : System.Net.NameResolution.dasm - System.Net.NameResolutionPal:ParseHostEntry(Interop+Sys+HostEntry,bool,byref,byref,byref) (FullOpts)
          -1 (-0.41 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.Marshalling.ComVariant:ThrowIfNotVarType(int[]):this (FullOpts)

Top method improvements (percentages):
          -4 (-6.78 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.ContentType:IsLinearWhiteSpaceChar(char):bool (FullOpts)
          -4 (-5.06 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[double]:Contains(double):bool:this (FullOpts)
          -4 (-5.06 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[int]:Contains(int):bool:this (FullOpts)
          -4 (-5.06 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[long]:Contains(long):bool:this (FullOpts)
          -4 (-4.82 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[byte]:Contains(byte):bool:this (FullOpts)
          -4 (-4.82 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[short]:Contains(short):bool:this (FullOpts)
          -4 (-4.35 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.IgnoreReferenceResolver:ContainsReferenceForCycleDetection(System.Object):bool:this (FullOpts)
          -4 (-3.88 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[System.Numerics.Vector`1[float]]:Contains(System.Numerics.Vector`1[float]):bool:this (FullOpts)
          -4 (-3.85 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[System.Nullable`1[int]]:Contains(System.Nullable`1[int]):bool:this (FullOpts)
          -4 (-1.65 % of base) : System.Collections.dasm - System.Collections.Generic.Stack`1[System.__Canon]:Contains(System.__Canon):bool:this (FullOpts)
          -1 (-0.41 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.Marshalling.ComVariant:ThrowIfNotVarType(int[]):this (FullOpts)
          -2 (-0.39 % of base) : System.Net.WebProxy.dasm - System.Net.WebProxy:IsLocal(System.Uri):bool (FullOpts)
          -1 (-0.27 % of base) : System.Net.Http.dasm - System.Net.Http.Headers.ObjectCollection`1[System.__Canon]:Remove(System.__Canon):bool:this (FullOpts)
          -1 (-0.24 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.CultureInfoConverter:GetStandardValues(System.ComponentModel.ITypeDescriptorContext):System.ComponentModel.TypeConverter+StandardValuesCollection:this (FullOpts)
          -1 (-0.19 % of base) : System.Formats.Asn1.dasm - System.Formats.Asn1.AsnWriter+Scope:Dispose():this (FullOpts)
          -1 (-0.11 % of base) : System.Net.NameResolution.dasm - System.Net.NameResolutionPal:ParseHostEntry(Interop+Sys+HostEntry,bool,byref,byref,byref) (FullOpts)
          -4 (-0.10 % of base) : System.Net.Security.dasm - System.Net.Security.SslStream:SelectClientCertificate():System.Security.Cryptography.X509Certificates.X509Certificate2:this (FullOpts)
          -1 (-0.04 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.PartBasedPackageProperties:ParseCorePropertyPart(System.IO.Packaging.PackagePart):this (FullOpts)

18 total methods with Code Size differences (18 improved, 0 regressed), 250785 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions