Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fluid container item converter #3533

Conversation

repo-alt
Copy link
Contributor

(Volumetric flask, certus tank, universal cell, etc.)
GTNewHorizons/GT-New-Horizons-Modpack#8807

"fluid_hasTag" key may look dubious, but it corresponds to the ConverterItemStack

@asiekierka
Copy link
Contributor

Would it be a better idea to consider appending a fluid map instead, to both make the relationship clearer (item contains a fluid) and to resolve the naming conundrum? Like how enchantments are a list of maps...

@asiekierka asiekierka added this to the OC 1.8.0 milestone Aug 29, 2022
@asiekierka asiekierka modified the milestones: OC 1.8.0, OC 1.9.0, OC 1.8.2 May 30, 2023
@asiekierka asiekierka closed this in 9374077 Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants