Fix runClient and runServer Gradle tasks #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile dependencies are placed on the runtime classpath by Gradle. Because the compile configuration is set to extend from the provided config, all of those dependencies are put on the runtime classpath as well. In this patch, provided is instead made a separate configuration, and explicitly added to ONLY the compile classpath of the main sourceset.
|
can you make it so the dependencies for OpenComputers_main also import correctly? this seems to only fix OpenComputers_api also, for 1.7.10 the _api and _main moduels are both pointing to the same output path: |
|
This patch was only intended to fix running from the command line, but I'm happy to go further with it to fix IDEA project import/generation. I'll see what I can do. |
|
if you find what is needed for the other fixes, i'd appreciate the PR for those things. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compiledependencies are placed on the runtime classpath by Gradle. Because thecompileconfiguration is set to extend from theprovidedconfig, all of those dependencies are put on the runtime classpath as well. That might be okay, except the set of dependencies certainly don't make up a functional modpack, so you end up with Forge spitting up dependency problems before you can reach the menu.In this patch,
providedis instead made a separate configuration, and explicitly added to ONLY the compile classpath of the main sourceset. This is what newer versions of ForgeGradle do, and it's also what's being done by setting dependencies to IDEA's "Provided" scope in the wiki's build instructions.Resolves #2561 and resolves #2614.