-
Notifications
You must be signed in to change notification settings - Fork 28
Fix midtrans-python-client to support windows environment #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To support Windows
|
(this is bugfix) |
|
Nice, thanks for the contribution! @hyuma The best way to fix Windows compatibility and retain Python 2.7 compatibility is by following this sample Would you like to try to add that? |
rizdaprasetya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow: #12 (comment)
|
Hi @rizdaprasetya , should we just make release version/branch/tag for backward compatibility?
also the other reason is python 2 already dead almost 2 years ago. though? |
|
@mashanz correct, thanks for notifying, sorry we haven't review this for a while. Agree with your suggestion, esp. since python 2 is no longer supported officially. we'll use better version tagging to handle such compatibility concerns. Also if you see any more compatibility issue to latest/current python version feel free to let us know by opening issue/PR. Cheers! |
- for better compatibility across OS (esp Windows) & latest official python version (Python 3) - may not work on Python 2 anymore
rizdaprasetya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To support Windows.
Without this fix,
UnicodeDecodeError: 'cp932' codec can't decode byte 0xef in position 515: illegal multibyte sequencewill occor whenpip install