Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sample app - add note and warning message #36

Merged
merged 4 commits into from
Sep 22, 2021
Merged

sample app - add note and warning message #36

merged 4 commits into from
Sep 22, 2021

Conversation

omarxp
Copy link
Contributor

@omarxp omarxp commented Sep 17, 2021

add note and warning message

rizdaprasetya
rizdaprasetya requested changes Sep 20, 2021
View reviewed changes
Copy link
Collaborator

@rizdaprasetya rizdaprasetya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall nice, this PR improves example quality & fix some typo 👍
Just few feedbacks to address here. Thanks!

examples/coreApi/coreApiCreditCardExample.js Outdated Show resolved Hide resolved
examples/expressApp/app.js Show resolved Hide resolved
examples/expressApp/package-lock.json Show resolved Hide resolved
rizdaprasetya
rizdaprasetya approved these changes Sep 22, 2021
View reviewed changes
Copy link
Collaborator

@rizdaprasetya rizdaprasetya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice work, will be merged thanks!

@rizdaprasetya rizdaprasetya merged commit b25bfd2 into Midtrans:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rizdaprasetya rizdaprasetya rizdaprasetya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omarxp @rizdaprasetya