-
Notifications
You must be signed in to change notification settings - Fork 57
Add RuntimeChannelPreferenceSet.md #3695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-risney
reviewed
Aug 8, 2023
david-risney
requested changes
Aug 8, 2023
david-risney
requested changes
Aug 18, 2023
kmahone
reviewed
Sep 15, 2023
oldnewthing
reviewed
Sep 19, 2023
FrankC-msft
reviewed
Sep 20, 2023
dmachaj
reviewed
Sep 21, 2023
dmachaj
reviewed
Sep 21, 2023
david-risney
requested changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update per review feedback.
specs/ReleaseChannelPreferenceSet.md
Outdated
// The Dev Runtime channel that is released weekly. | ||
Dev = 4, | ||
// The Canary Runtime channel that is released daily. | ||
Canary = 8, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding overloads of the version strings where we pull the channel out of the string as one of these enums
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API Proposal Review
WebView2 API Proposal for review.
review completed
WebView2 API Proposal that's been reviewed and now needs final update and push
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.