Skip to content

fix(docs): update shell integration settings.json codeblock #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

david-ly
Copy link

Updated the settings.json codeblock according to the current schema

  • Refactored the actions array to reflect the current element structure which no longer stores associated keystrokes as it appears shortcut definitions have been moved into the keybindings prop
  • Removed the selectCommand/selectOutput actions as they don't appear to be valid anymore given the current ShortcutActionName enums
  • Cleaned up indentation (tab size: 2 spaces) for consistency with the other code sections

Copy link

Learn Build status updates of commit be3bb47:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/tutorials/shell-integration.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Updated the `settings.json` codeblock according to the current [schema](https://aka.ms/terminal-profiles-schema)
- Refactored the `actions` array to reflect the current element structure which no longer stores associated keystrokes as it appears shortcut definitions have been moved into the `keybindings` prop
- Removed the `selectCommand`/`selectOutput` actions as they don't appear to be valid anymore given the current `ShortcutActionName` enums
- Cleaned up indentation (tab size: 2 spaces) for consistency with the other code sections on this page
@david-ly
Copy link
Author

@microsoft-github-policy-service agree

Copy link

Learn Build status updates of commit 40786b1:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/tutorials/shell-integration.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

@suswan99 suswan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants