Fix some bugs in initial bot creation steps #184
Merged
+6
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sgellock
commented
Jul 12, 2018
sgellock
commented
- removed unnecessary npm init
- also removed the npm install commands that added bot fx components to the unused package.json created in the above step
- moved the NOTE about possibly requiring windows-build tools closer to the pre-reqs section. It's my observation that on a clean Win 10, this is required in order to get c++ compilers and python 2.x installed. these are both required for the restify component
- made the commandline for installing generator-botbuilder@perview consistent with how we issue other npm install commands
- removed unnecessary npm init - also removed the npm install commands that added bot fx components to the unused package.json created in the above step - moved the NOTE about possibly requiring windows-build tools closer to the pre-reqs section. It's my observation that on a clean Win 10, this is required in order to get c++ compiliers and python 2.x installed. these are both required for the restify component - made the commandline for installing generator-botbuilder@perview consistent with how we issue other npm install commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.