Skip to content

Update flask postgres tutorial with clarifications and more information #14885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9 commits merged into from
Sep 28, 2018

Conversation

nnja
Copy link
Contributor

@nnja nnja commented Sep 12, 2018

Made the following changes to update the tutorial and clarify some of the steps:

  • Cleaned up extraneous whitespace
  • Fixed the command to connect to postgres locally
  • Added a note about a common issue on postgres installs on osx
  • Removed duplicate 'try it' section for cloud shell
  • Replaced the sku-name value on the Postgres instance creation with one of a lower price tier, and added an explanation of what the sku-name flag is used for.
  • Cleaned up the firewall rules section, fixed a mistaken description, and added extra clarification around the rule for allowing Azure IPs
  • Added a section to the end to walk through cleaning up resources created in this tutorial.

Includes clean up for the sample code, via Azure-Samples/docker-flask-postgres#3

@PRMerger13
Copy link
Contributor

@nnja : Thanks for your contribution! The author, @berndverst, has been notified to review your proposed change.

@nnja
Copy link
Contributor Author

nnja commented Sep 12, 2018

CC @cephalin

@nnja nnja changed the title Fix flask postgres tutorial Update flask postgres tutorial with clarifications and more information Sep 12, 2018
@ktoliver
Copy link
Contributor

@nnja

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. When you work in the private repo, after you review staging and fix all validation issues, you can add the sign-off comment to let the reviewers know the updates are ready to be merged. Read about article authors working in the public repo for more information.

Would you close this pull request and submit the content in a pull request in the private repo, so automation can take the corresponding action? Thank you.

@cephalin
Copy link
Contributor

@nnja Actually also we're in the process of updating the tutorial to target the Python built-in image. Let's merge this change into that work because there will be quite a bit of structural changes to the sample repo.

@nnja
Copy link
Contributor Author

nnja commented Sep 14, 2018

Hi @ktoliver. Thanks for the info! Since @cephalin has in flight changes to this doc, he requested that I leave this PR as is for now. I'll make future updates in the private repo.

@cephalin
Copy link
Contributor

@nnja please close this now in lieu of the other PR

@ghost ghost merged commit 358e81a into MicrosoftDocs:master Sep 28, 2018
@nnja nnja deleted the fix_flask_postgres_tutorial branch October 5, 2018 00:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants