Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section for basemap customization #125912

Merged
merged 18 commits into from
Feb 28, 2025

Conversation

zhz0704
Copy link
Contributor

@zhz0704 zhz0704 commented Feb 25, 2025

Reopen of #125895
We need this PR on public repo because we need our tech writer @stevemunk to review it. Thanks.

Copy link
Contributor

@zhz0704 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit dae5d47:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-maps/choose-map-style.md ✅Succeeded
articles/azure-maps/media/choose-map-style/admin-district.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/admin-district2.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/building-footprint.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/country-region.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/road-details.gif ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).
CodePen PR contains one or more CodePen iframe, which must be human reviewed to ensure requirements are met.

@ttorble
Copy link
Contributor

ttorble commented Feb 25, 2025

@sinnypan

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Feb 25, 2025
Copy link
Contributor

Learn Build status updates of commit 919bef0:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-maps/choose-map-style.md ✅Succeeded
articles/azure-maps/media/choose-map-style/admin-district.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/admin-district2.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/building-footprint.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/country-region.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/road-details.gif ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).
CodePen PR contains one or more CodePen iframe, which must be human reviewed to ensure requirements are met.

Copy link
Contributor

Learn Build status updates of commit b6cd9fa:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-maps/choose-map-style.md ✅Succeeded
articles/azure-maps/media/choose-map-style/admin-district.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/admin-district2.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/building-footprint.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/country-region.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/road-details.gif ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).
CodePen PR contains one or more CodePen iframe, which must be human reviewed to ensure requirements are met.

Copy link

@sinnypan sinnypan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhz0704 Thanks so much, let’s get it live

@sinnypan
Copy link

#sign-off

@sinnypan
Copy link

@ttorble could you help to review and merge this doc PR? Thank you.

zhz0704 and others added 10 commits February 28, 2025 01:18
Co-authored-by: Courtney Wales <62625502+Court72@users.noreply.github.com>
Co-authored-by: Courtney Wales <62625502+Court72@users.noreply.github.com>
Co-authored-by: Courtney Wales <62625502+Court72@users.noreply.github.com>
Co-authored-by: Courtney Wales <62625502+Court72@users.noreply.github.com>
Co-authored-by: Courtney Wales <62625502+Court72@users.noreply.github.com>
Co-authored-by: Courtney Wales <62625502+Court72@users.noreply.github.com>
Co-authored-by: Courtney Wales <62625502+Court72@users.noreply.github.com>
Co-authored-by: Courtney Wales <62625502+Court72@users.noreply.github.com>
Co-authored-by: Courtney Wales <62625502+Court72@users.noreply.github.com>
Copy link
Contributor

Learn Build status updates of commit d5ccbee:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-maps/choose-map-style.md ✅Succeeded
articles/azure-maps/media/choose-map-style/admin-district.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/admin-district2.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/building-footprint.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/country-region.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/road-details.gif ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).
CodePen PR contains one or more CodePen iframe, which must be human reviewed to ensure requirements are met.

Copy link
Contributor

Learn Build status updates of commit d353b88:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/azure-maps/choose-map-style.md ⚠️Warning Details
articles/azure-maps/media/choose-map-style/admin-district.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/admin-district2.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/building-footprint.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/country-region.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/road-details.gif ✅Succeeded

articles/azure-maps/choose-map-style.md

  • Line 129, Column 1: [Warning: file-not-found - See documentation] Invalid file link: './media/choose-map-style/admin-district2.gif'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

@sinnypan sinnypan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#sign-off

Copy link
Contributor

@sinnypan, you can only sign off in the main PR conversation, not in review comments.

@sinnypan
Copy link

#sign-off

@sinnypan
Copy link

@Court72 please review again and merge PR. We need this go live soon, thanks.

Copy link
Contributor

Learn Build status updates of commit 44e1e8f:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-maps/choose-map-style.md ✅Succeeded
articles/azure-maps/media/choose-map-style/admin-district-2.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/admin-district.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/building-footprint.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/country-region.gif ✅Succeeded
articles/azure-maps/media/choose-map-style/road-details.gif ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).
CodePen PR contains one or more CodePen iframe, which must be human reviewed to ensure requirements are met.

@zhz0704
Copy link
Contributor Author

zhz0704 commented Feb 28, 2025

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @sinnypan

@sinnypan
Copy link

#sign-off

@ttorble ttorble merged commit 0ad2a07 into MicrosoftDocs:main Feb 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants