Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Key Vault RBAC permission #125003

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

bolt-io
Copy link
Contributor

@bolt-io bolt-io commented Dec 2, 2024

This include appears in the following doc: https://learn.microsoft.com/en-us/azure/api-management/api-management-howto-properties?tabs=azure-portal#configure-access-to-key-vault

This refers to adding Named Values to API Management using Key Vault. As Named Values in key vault can only be secrets the correct RBAC permissions is Key Vault Secrets User and not Key Vault Certificate User

Copy link
Contributor

@bolt-io : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit b13f43d:

✅ Validation status: passed

File Status Preview URL Details
includes/api-management-key-vault-access.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ttorble
Copy link
Contributor

ttorble commented Dec 2, 2024

@dlepow

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Dec 2, 2024
Copy link
Contributor

@dlepow dlepow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bolt-io - You are correct and thank you for pointing out the error! Unfortunately the correction you made is in a file that is shared in several other contexts, including for certificates (where the existing permissions remain correct, I believe). I will pull your commit into a separate PR to make the correction in the location for named values only. After the correction is published, I will update and close this PR. Cheers.

@learn-build-service-prod learn-build-service-prod bot merged commit 4d26aa6 into MicrosoftDocs:main Feb 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants