Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#124405 - private link dns details for web apps that use unique default hostnames #124485

Closed

Conversation

mikeclayton
Copy link

Per Issue #124405 (Add DNS info for Azure Private Link with App Services that use "Unique Default Hostnames"), added info to clarify dns hostnames / zones for web apps configured to use / not use Unique Default Hostnames.

Web apps that are configured to use Unique Default Hostnames have an additional <region> domain part, and it's not immediately clear from the current documentation what to do with it when creating private links on these web apps.

The update provides additional details for these web apps.

@mikeclayton
Copy link
Author

Note - I've copied the [Without unique default hostnames](#tab/without-unique-default-hostnames) syntax from other documentation in the hope it will generate tabbed sections for "Without unique default hostnames" and "With unique default hostnames" - something like this:

https://learn.microsoft.com/en-us/azure/event-grid/subscribe-to-graph-api-events?tabs=http#:~:text=updated%2C%20or%20deleted.-,HTTP,Python,-HTTP

image

but I'm not really sure how that works or how to render the markdown locally to see what it ends up like, so it might be a bit of a mess...

Copy link
Contributor

@mikeclayton : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 616bd67:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/app-service/overview-private-endpoint.md ⚠️Warning Details

articles/app-service/overview-private-endpoint.md

  • Line 65, Column 1: [Warning: invalid-tab-group - See documentation] Duplicate tab id: (without-unique-default-hostnames, 5),(with-unique-default-hostnames, 5).
  • Line 133, Column 8: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/private-link/private-endpoint-dns-integration#private-dns-zone-group' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 133, Column 8: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/private-link/private-endpoint-dns-integration#private-dns-zone-group' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Sep 23, 2024

@madsd
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Sep 23, 2024
Copy link
Contributor

Learn Build status updates of commit 1297013:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/app-service/overview-private-endpoint.md ⚠️Warning Details

articles/app-service/overview-private-endpoint.md

  • Line 65, Column 1: [Warning: invalid-tab-group - See documentation] Duplicate tab id: (without-unique-default-hostnames, 4),(with-unique-default-hostnames, 4).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

|myapp-&lt;hash&gt;.&lt;region&gt;.azurewebsites.net|CNAME|clustername.azurewebsites.windows.net|
|clustername.azurewebsites.windows.net|CNAME|cloudservicename.&lt;region&gt;.cloudapp.net|
|cloudservicename.&lt;region&gt;.cloudapp.net|A|40.122.110.154|

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---

|mywebapp.&lt;region&gt;.privatelink.azurewebsites.net|CNAME|clustername.azurewebsites.windows.net|
|clustername.azurewebsites.windows.net|CNAME|cloudservicename.&lt;region&gt;.cloudapp.azure.com|
|cloudservicename.&lt;region&gt;cloudapp.net|A|40.122.110.154|<--This public IP isn't your private endpoint, you receive a 403 error|

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---

For more information, see [custom DNS validation](./app-service-web-tutorial-custom-domain.md).

### Azure Private DNS Zones
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Azure Private DNS Zones
---
### Azure Private DNS Zones

@madsd
Copy link
Contributor

madsd commented Sep 24, 2024

@mikeclayton Hi Michael, appreciate your suggestion, but must honestly say that I think it adds more confusion. As you also point out at the end in your created issue, the handling of DNS with or without unique names is exactly the same - just that the name of the app is the full unique name rather than just the app short name. vs <app-name + hash + region>, but everything else is the same.

I can add an explicit note about that at the beginning of the DNS section if you think that would help clarify.

Thanks,
Mads

@mikeclayton
Copy link
Author

@madsd - yeah, that's fair.

I figured explicitly listing everything again the Unique Default Hostnames was more "complete", but maybe it's a bit much - it just needs something to make it clear what to do with the really (even if it's "ignore it for the Azure Private DNS Zone name"!).

I'm happy with whatever you think will be clearer really...

@madsd
Copy link
Contributor

madsd commented Sep 25, 2024

@mikeclayton Adding this extended description to the DNS intro. Should be live in about 12 hours.

image

@madsd
Copy link
Contributor

madsd commented Sep 25, 2024

#please-close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants