Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sql-data-warehouse-manage-monitor.md #124476

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

Yazdanifard
Copy link
Contributor

The link was wrong

Copy link
Contributor

@Yazdanifard : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit ecae860:

💡 Validation status: suggestions

File Status Preview URL Details
articles/synapse-analytics/sql-data-warehouse/sql-data-warehouse-manage-monitor.md 💡Suggestion Details

articles/synapse-analytics/sql-data-warehouse/sql-data-warehouse-manage-monitor.md

  • Line 102, Column 64: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /sql/relational-databases/system-dynamic-management-views/sys-dm-pdw-sql-requests-transact-sql?view=aps-pdw-2016-au7

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Sep 20, 2024

@WilliamDAssafMSFT
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Sep 20, 2024
@WilliamDAssafMSFT
Copy link
Contributor

Hi @Yazdanifard! Thanks for taking the time to create this pull request. Nice catch. I suggested a correction to the end of the URL. Please accept the commit suggestion, and we'll get this fix merged in.

@WilliamDAssafMSFT
Copy link
Contributor

Reminder - @Yazdanifard. Please accept the commit suggestion, and we'll get this fix merged in.

@Yazdanifard
Copy link
Contributor Author

@WilliamDAssafMSFT Thank you for your message & review.
I resolved the issue. Is it the correct way? Otherwise, let me know what I should do.
Thanks!

@WilliamDAssafMSFT
Copy link
Contributor

Almost! Unresolve the comment, then commit the suggestion. Then, we can move forward.

…se-manage-monitor.md

Co-authored-by: William Assaf MSFT <74387232+WilliamDAssafMSFT@users.noreply.github.com>
Copy link
Contributor

Learn Build status updates of commit aa83d85:

💡 Validation status: suggestions

File Status Preview URL Details
articles/synapse-analytics/sql-data-warehouse/sql-data-warehouse-manage-monitor.md 💡Suggestion Details

articles/synapse-analytics/sql-data-warehouse/sql-data-warehouse-manage-monitor.md

  • Line 102, Column 64: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /sql/relational-databases/system-dynamic-management-views/sys-dm-pdw-sql-requests-transact-sql?view=azure-sqldw-latest

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Yazdanifard
Copy link
Contributor Author

Should I close this PR now?

Copy link
Contributor

Learn Build status updates of commit aa83d85:

💡 Validation status: suggestions

File Status Preview URL Details
articles/synapse-analytics/sql-data-warehouse/sql-data-warehouse-manage-monitor.md 💡Suggestion Details

articles/synapse-analytics/sql-data-warehouse/sql-data-warehouse-manage-monitor.md

  • Line 102, Column 64: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /sql/relational-databases/system-dynamic-management-views/sys-dm-pdw-sql-requests-transact-sql?view=azure-sqldw-latest

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@WilliamDAssafMSFT
Copy link
Contributor

@Yazdanifard sorry for the delay. Please accept the latest suggestion, then we can merge.

…se-manage-monitor.md

Co-authored-by: William Assaf MSFT <74387232+WilliamDAssafMSFT@users.noreply.github.com>
Copy link
Contributor

Learn Build status updates of commit 564a480:

✅ Validation status: passed

File Status Preview URL Details
articles/synapse-analytics/sql-data-warehouse/sql-data-warehouse-manage-monitor.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@WilliamDAssafMSFT
Copy link
Contributor

#sign-off

@Court72 Court72 merged commit e9c943b into MicrosoftDocs:main Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants