Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy-data-connector-agent-container.md to reflect correct required role. #124450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yarpX
Copy link

@yarpX yarpX commented Sep 18, 2024

Changed role required to write secrets to key vault that SAP agent will use from "Key Vault Secrets Officer" to "Key Vault Contributor". Writing to a secret requires management plane access, not data plane access - see MS Ticket 2408280040007879

Changed role required to write secrets to key vault that SAP agent will use from "Key Vault Secrets Officer" to "Key Vault Contributor". Writing to a secret requires management plane access, not data plane access - see MS Ticket 2408280040007879
Copy link
Contributor

@yarpX : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 2b02670:

✅ Validation status: passed

File Status Preview URL Details
articles/sentinel/sap/deploy-data-connector-agent-container.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Sep 18, 2024

@batamig

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Sep 18, 2024
@batamig
Copy link
Contributor

batamig commented Sep 22, 2024

Hi @yarpX, thanks for your contribution! I'm just validating this with the technical team and will then merge if approved.

@batamig
Copy link
Contributor

batamig commented Sep 26, 2024

Hi @yarpX, thanks again for your feedback. I'm tagging our engineers to follow up on this with you.

@dvir-ms @kingwil can you help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants