Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default-outbound-access.md #124416

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PeterDeThier-MSFT
Copy link
Contributor

@PeterDeThier-MSFT PeterDeThier-MSFT commented Sep 12, 2024

Added examples for GUI, az cli, and Powershell. Removed blurbs about private subnet not being a changeable setting after the subnet is created as this is no longer the case.

Copy link
Contributor

@PeterDeThier-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit b016dee:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-network/ip-services/default-outbound-access.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@Court72
Copy link
Contributor

Court72 commented Sep 13, 2024

@mbender-ms

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Sep 13, 2024
@PeterDeThier-MSFT
Copy link
Contributor Author

Consolidated changes from PRs below into this one, removed blurbs about private subnet not being a changeable setting post-creation of subnet as this is no longer the case

#124414
#124413

Copy link
Contributor

Learn Build status updates of commit a04edea:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-network/ip-services/default-outbound-access.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@mbender-ms
Copy link
Contributor

#assign-reviewer: @brianlehr

@brianlehr
Copy link
Contributor

brianlehr commented Sep 13, 2024

@PeterDeThier-MSFT thanks for this, but the reason we were not putting this in the documentation is because it's an upcoming annoucement (existing subnets being modifiable). I'll review your edits and see what we can use at that time.

@mbender-ms
Copy link
Contributor

#draft

@mbender-ms
Copy link
Contributor

@brianlehr Would you like this closed?

@brianlehr
Copy link
Contributor

@brianlehr Would you like this closed?

Let's leave it open for now. We may be able to leverage soon.

Copy link
Contributor

@mbender-ms mbender-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants