Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storage-blob-static-website.md #123988

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

srajaramANP
Copy link
Contributor

Updating a Public Documentation FAQ regarding the PE Enabled and not able to access static websites in storage account.

Updating a Public Documentation FAQ regarding the PE Enabled and not able to access static websites in storage account.
Copy link
Contributor

@srajaramANP : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@stevenmatthew
Copy link
Contributor

@srajaramANP Thanks for the submission! I think this would be useful information! A couple of quick points:

  • The update begins on line number 119, just below the bookmark for the FAQ item "Do static websites support Microsoft Entra ID?". I'd suggest moving your new entry to line number 143, at the bottom of the FAQ.
  • Your entry suggests a resolution step (which is awesome!); can this be linked to the article which details how to perform the resolution step(s)? If not, we'll need to consider adding these steps to an existing article and publishing both changes at once.

If you're up for this, I'd be happy to work with you on this; if not, I'll add it to my work items and begin on it ASAP.

Thanks again for reaching out!

@srajaramANP
Copy link
Contributor Author

@srajaramANP Thanks for the submission! I think this would be useful information! A couple of quick points:

  • The update begins on line number 119, just below the bookmark for the FAQ item "Do static websites support Microsoft Entra ID?". I'd suggest moving your new entry to line number 143, at the bottom of the FAQ.
  • Your entry suggests a resolution step (which is awesome!); can this be linked to the article which details how to perform the resolution step(s)? If not, we'll need to consider adding these steps to an existing article and publishing both changes at once.

If you're up for this, I'd be happy to work with you on this; if not, I'll add it to my work items and begin on it ASAP.

Thanks again for reaching out!

Sure, I can Move to Line Number 143 and also, I added resolution step in More detail by creating the private endpoint will resolve the issue of not accessing when Private endpoints are created for blob, Queue.

Copy link
Contributor

Learn Build status updates of commit 87c94ba:

✅ Validation status: passed

File Status Preview URL Details
articles/storage/blobs/storage-blob-static-website.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Updating static Website public documentation which mentions scenario of private endpoint enable for blob and how to access the static websites.
Copy link
Contributor

Learn Build status updates of commit cba1700:

✅ Validation status: passed

File Status Preview URL Details
articles/storage/blobs/storage-blob-static-website.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Aug 5, 2024

@stevenmatthew

When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Aug 5, 2024
@srajaramANP
Copy link
Contributor Author

srajaramANP commented Aug 6, 2024

@stevenmatthew I have updated the changes requested. Any update on the review?

Copy link
Contributor

Learn Build status updates of commit cba1700:

✅ Validation status: passed

File Status Preview URL Details
articles/storage/blobs/storage-blob-static-website.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Sep 20, 2024

@stevenmatthew

Can you review this old PR and determine whether it needs to be closed or merged?

@v-ccolin
Copy link
Contributor

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

@PMEds28
Copy link
Contributor

PMEds28 commented Dec 22, 2024

@stevenmatthew

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

@v-dirichards
Copy link
Contributor

@stevenmatthew Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

@v-ccolin
Copy link
Contributor

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants