Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for installing on Mariner #3111

Merged
merged 1 commit into from
May 10, 2022
Merged

Add doc for installing on Mariner #3111

merged 1 commit into from
May 10, 2022

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Apr 29, 2022

Mariner 1.0 and 2.0 are now supported.

See Azure/azure-cli#22034

@opbld32
Copy link

opbld32 commented Apr 29, 2022

Docs Build status updates of commit fe47183:

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/includes/cli-install-linux-tdnf.md ✅Succeeded View
docs-ref-conceptual/install-azure-cli-linux.md ✅Succeeded View
docs-ref-conceptual/zone-pivot-groups.json ✅Succeeded
docs-ref-conceptual/zone-pivot-groups.yml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Comment on lines +11 to +12
- id: tdnf
title: tdnf (Mariner)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbradish-microsoft, which zone-pivot-groups is actually used? The JSON one or the YAML one?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiasli , YML, so I don't know why we even have a JSON. I'm checking with @DavidCBerry13 to see why he added both.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiasli, here's the scoop ... Our repo, for unknown reason, is not handling the traditional zone pivot setup. In this screen print, you'll see a reference on line 12 ...
image

... this is because this is actually an internal JSON file that gets built during the publishing process sourcing from the YML file. The JSON file of the same name, checked into GitHub, is not in use and @DavidCBerry13, who originally setup our zone pivot repo files, is deleting it.

ACTION ITEM: Remove the docs-ref-conceptual/zone-pivot-groups.json file from this PR.

Comment on lines +11 to +12
- id: tdnf
title: tdnf (Mariner)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiasli, here's the scoop ... Our repo, for unknown reason, is not handling the traditional zone pivot setup. In this screen print, you'll see a reference on line 12 ...
image

... this is because this is actually an internal JSON file that gets built during the publishing process sourcing from the YML file. The JSON file of the same name, checked into GitHub, is not in use and @DavidCBerry13, who originally setup our zone pivot repo files, is deleting it.

ACTION ITEM: Remove the docs-ref-conceptual/zone-pivot-groups.json file from this PR.

@DavidCBerry13
Copy link
Contributor

@dbradish-microsoft @jiasli - I just put a PR out there to delete that zone-pivot-groups.json file. Two options here.

  1. Merge my PR in and the @jiasli should rebase off my PR
  2. Close my PR and @jiasli deletes the file in his PR (making my PR unneeded)

Either one works, so @jiasli I think it is really up to you in terms of what is easier for you.

@opbld32
Copy link

opbld32 commented May 5, 2022

Docs Build status updates of commit aaf6b85:

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/includes/cli-install-linux-tdnf.md ✅Succeeded View
docs-ref-conceptual/install-azure-cli-linux.md ✅Succeeded View
docs-ref-conceptual/zone-pivot-groups.yml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@jiasli
Copy link
Member Author

jiasli commented May 5, 2022

Thanks @dbradish-microsoft, @DavidCBerry13, Done! I have rebased by PR.😊

@jiasli jiasli merged commit 4bc9965 into MicrosoftDocs:main May 10, 2022
@jiasli jiasli deleted the tdnf branch May 10, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants