-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc for installing on Mariner #3111
Conversation
Docs Build status updates of commit fe47183: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
- id: tdnf | ||
title: tdnf (Mariner) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbradish-microsoft, which zone-pivot-groups
is actually used? The JSON one or the YAML one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiasli , YML, so I don't know why we even have a JSON. I'm checking with @DavidCBerry13 to see why he added both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiasli, here's the scoop ... Our repo, for unknown reason, is not handling the traditional zone pivot setup. In this screen print, you'll see a reference on line 12 ...
... this is because this is actually an internal JSON file that gets built during the publishing process sourcing from the YML file. The JSON file of the same name, checked into GitHub, is not in use and @DavidCBerry13, who originally setup our zone pivot repo files, is deleting it.
ACTION ITEM: Remove the docs-ref-conceptual/zone-pivot-groups.json file from this PR.
- id: tdnf | ||
title: tdnf (Mariner) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiasli, here's the scoop ... Our repo, for unknown reason, is not handling the traditional zone pivot setup. In this screen print, you'll see a reference on line 12 ...
... this is because this is actually an internal JSON file that gets built during the publishing process sourcing from the YML file. The JSON file of the same name, checked into GitHub, is not in use and @DavidCBerry13, who originally setup our zone pivot repo files, is deleting it.
ACTION ITEM: Remove the docs-ref-conceptual/zone-pivot-groups.json file from this PR.
@dbradish-microsoft @jiasli - I just put a PR out there to delete that zone-pivot-groups.json file. Two options here.
Either one works, so @jiasli I think it is really up to you in terms of what is easier for you. |
Docs Build status updates of commit aaf6b85: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Thanks @dbradish-microsoft, @DavidCBerry13, Done! I have rebased by PR.😊 |
Mariner 1.0 and 2.0 are now supported.
See Azure/azure-cli#22034