Skip to content

Added docs for Animation package revamp #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 8, 2021
Merged

Added docs for Animation package revamp #443

merged 12 commits into from
Mar 8, 2021

Conversation

@Sergio0694
Copy link
Contributor

@Sergio0694 Sergio0694 commented Feb 19, 2021 •
edited
Loading

Docs for CommunityToolkit/WindowsCommunityToolkit#3639

What changes to the docs does this PR provide?

Added new docs for:

  • AnimationBuilder
  • AnimationSet
  • ImplicitAnimationSet
  • Related APIs

Updated docs for ItemsReorderAnimation.

Also removed the old docs for types that are now gone.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Correctly picked the right branch to base the change off (master for new features, live for typos/improvements)
  • For new pages, used the provided template
  • For new features, added an entry in the Table of Contents
  • Ran against a spell and grammar checker
  • Contains NO breaking changes

@Sergio0694 Sergio0694 force-pushed the feature/animations-revamp branch from 10122ba to c6a0f9d Compare February 19, 2021 21:27
michael-hawker
michael-hawker requested changes Feb 24, 2021
View reviewed changes
Copy link
Collaborator

@michael-hawker michael-hawker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For any removed docs, we should leave a stub and eventually provide a migration to the new format. For now, we should add a deprecation notice at the top.

And we should move them to the 'archived' branch of the TOC, but not move the file locations (for now)

@Sergio0694 Sergio0694 force-pushed the feature/animations-revamp branch from 43bc86c to 60bf2f3 Compare March 1, 2021 21:30
@Sergio0694
Copy link
Contributor Author

@michael-hawker I've reverted those changes with a rebase and added those deprecation banners instead, thanks! 🙂

michael-hawker
michael-hawker requested changes Mar 5, 2021
View reviewed changes
Copy link
Collaborator

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those animated GIFs are ginormous. Can we crop them and optimize them a bit? We should also have them say "This is Sample Text".

docs/animations/CompositionAnimations.md
Comment on lines +10 to +12
> [!WARNING]
> These animation types have been updated with some breaking changes, please refer to the docs for the [`AnimationSet`](AnimationSet.md) and [`ImplicitAnimationSet`](ImplicitAnimationSet.md) types. For a comprehensive list of all the available APIs, use the .NET API browser instead.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much more of a release notes thing. Are all the samples below up-to-date to work with the new version? If so, I don't think we need this note here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, I've actually moved this whole page to the archive and split the docs into separate pages, since we now have the whole distinction between implicit/explicit animations (and the animation builder too) that wasn't there before. As in, this original docs page was covering mostly just the implicit ones in the old implementation, so I figured we'd just leave this here to avoid breaking links but then start fresh with the other new docs pages? 🤔

docs/animations/ImplicitAnimations.md

# Implicit Composition Animations in XAML

> [!WARNING]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples below are still workable in the new world, eh? But not in the new ImplicitAnimationSet document? Do we really need a new doc or can we just re-use the old one here and update it? (Just want to try and maybe create a bit less churn if we can?)

Copy link
Contributor Author

@Sergio0694 Sergio0694 Mar 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should roughly work without XAML changes I think (with some minor differences in some cases).
I just split the documents to clearly separate the various types though? As in, now we have the implicit/explicit sets, whereas before there was just that single set, and the various docs pages had more generic titles and names (eg. "composition animations"). My rationale here was that just using the type name for the file name and title would've made things easier to follow? Also to be consistent with the other docs from other sections. Thoughts? 🤔

docs/animations/ReorderGrid.md

# ReorderGridAnimation

> [!WARNING]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this seems churny too... Maybe I should go figure out the redirect stuff... ☹

@Sergio0694 Sergio0694 force-pushed the feature/animations-revamp branch from 60bf2f3 to 9f432d4 Compare March 5, 2021 19:05
@opbld31
Copy link

opbld31 commented Mar 5, 2021

Docs Build status updates of commit 9f432d4:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/animations/Offset.md ⚠️Warning View Details
docs/animations/AnimationBuilder.md ✅Succeeded View
docs/animations/AnimationSet.md ✅Succeeded View
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/ImplicitAnimationSet.md ✅Succeeded View
docs/animations/ImplicitAnimations.md ✅Succeeded View
docs/animations/ItemsReorderAnimation.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View
docs/resources/images/AnimationSet.gif ✅Succeeded View
docs/resources/images/EffectAnimations.gif ✅Succeeded View
docs/resources/images/ImplicitAnimationSet.gif ✅Succeeded View
docs/toc.md ✅Succeeded View

docs/animations/Offset.md

  • Line 123, Column 5: [Warning-duplicate-alt-text] Alt text 'Use Case 2 Output' is duplicated. Within an article, alt text must be unique.
  • Line 146, Column 5: [Warning-duplicate-alt-text] Alt text 'Use Case 2 Output' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@michael-hawker
Copy link
Collaborator

@Sergio0694 can you address the markdown linter errors?

@Sergio0694 Sergio0694 force-pushed the feature/animations-revamp branch from 9f432d4 to 69d4ee3 Compare March 7, 2021 22:38
@opbld30
Copy link

opbld30 commented Mar 7, 2021

Docs Build status updates of commit 69d4ee3:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/animations/Offset.md ⚠️Warning View Details
docs/animations/AnimationBuilder.md ✅Succeeded View
docs/animations/AnimationSet.md ✅Succeeded View
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/ImplicitAnimationSet.md ✅Succeeded View
docs/animations/ImplicitAnimations.md ✅Succeeded View
docs/animations/ItemsReorderAnimation.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View
docs/resources/images/AnimationSet.gif ✅Succeeded View
docs/resources/images/EffectAnimations.gif ✅Succeeded View
docs/resources/images/ImplicitAnimationSet.gif ✅Succeeded View
docs/toc.md ✅Succeeded View

docs/animations/Offset.md

  • Line 127, Column 5: [Warning-duplicate-alt-text] Alt text 'Use Case 2 Output' is duplicated. Within an article, alt text must be unique.
  • Line 151, Column 5: [Warning-duplicate-alt-text] Alt text 'Use Case 2 Output' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld30
Copy link

opbld30 commented Mar 7, 2021

Docs Build status updates of commit 1bf7585:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/animations/Offset.md ⚠️Warning View Details
docs/controls/datagrid_guidance/editing_inputvalidation.md ⚠️Warning View Details
docs/controls/datagrid_guidance/keyboard_navigation_selection.md ⚠️Warning View Details
docs/controls/datagrid_guidance/rowdetails.md ⚠️Warning View Details
docs/controls/datagrid_guidance/styling_formatting_options.md ⚠️Warning View Details
docs/extensions/ScrollViewerExtensions.md ⚠️Warning View Details
docs/brushes/BackdropBlurBrush.md 💡Suggestion View Details
docs/brushes/BackdropGammaTransferBrush.md 💡Suggestion View Details
docs/controls/wpf-winforms/WebView.md 💡Suggestion View Details
docs/controls/wpf-winforms/WebViewCompatible.md 💡Suggestion View Details
docs/animations/AnimationBuilder.md ✅Succeeded View
docs/animations/AnimationSet.md ✅Succeeded View
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/ImplicitAnimationSet.md ✅Succeeded View
docs/animations/ImplicitAnimations.md ✅Succeeded View
docs/animations/ItemsReorderAnimation.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View
docs/brushes/AcrylicBrush.md ✅Succeeded View
docs/brushes/BackdropInvertBrush.md ✅Succeeded View
docs/brushes/BackdropSaturationBrush.md ✅Succeeded View
docs/brushes/BackdropSepiaBrush.md ✅Succeeded View
docs/brushes/ImageBlendBrush.md ✅Succeeded View
docs/brushes/PipelineBrush.md ✅Succeeded View
docs/brushes/RadialGradientBrush.md ✅Succeeded View
docs/brushes/TilesBrush.md ✅Succeeded View
docs/controls/datagrid_guidance/customize_autogenerated_columns.md ✅Succeeded View
docs/controls/datagrid_guidance/datagrid_basics.md ✅Succeeded View
docs/controls/datagrid_guidance/group_sort_filter.md ✅Succeeded View
docs/extensions/IconMarkupExtensions.md ✅Succeeded View
docs/gaze/GazeInteractionLibrary.md ✅Succeeded View
docs/helpers/Triggers.md ✅Succeeded View
docs/resources/images/AnimationSet.gif ✅Succeeded View
docs/resources/images/EffectAnimations.gif ✅Succeeded View
docs/resources/images/ImplicitAnimationSet.gif ✅Succeeded View
docs/toc.md ✅Succeeded View

docs/animations/Offset.md

  • Line 127, Column 5: [Warning-duplicate-alt-text] Alt text 'Use Case 2 Output' is duplicated. Within an article, alt text must be unique.
  • Line 151, Column 5: [Warning-duplicate-alt-text] Alt text 'Use Case 2 Output' is duplicated. Within an article, alt text must be unique.

docs/controls/datagrid_guidance/editing_inputvalidation.md

  • Line 18, Column 1: [Warning-alt-text-bad-value] Alt text 'Editing' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
  • Line 54, Column 1: [Warning-alt-text-bad-value] Alt text 'Validation' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/controls/datagrid_guidance/keyboard_navigation_selection.md

  • Line 57, Column 1: [Warning-alt-text-bad-value] Alt text 'Selection' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/controls/datagrid_guidance/rowdetails.md

  • Line 12, Column 1: [Warning-alt-text-bad-value] Alt text 'RowDetails' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/controls/datagrid_guidance/styling_formatting_options.md

  • Line 26, Column 1: [Warning-alt-text-bad-value] Alt text 'Gridlines' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
  • Line 99, Column 1: [Warning-alt-text-bad-value] Alt text 'FrozenColumns' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
  • Line 112, Column 1: [Warning-alt-text-bad-value] Alt text 'ResizeColumns' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/extensions/ScrollViewerExtensions.md

  • Line 102, Column 1: [Warning-alt-text-bad-value] Alt text 'MiddleClickScrolling' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/brushes/BackdropBlurBrush.md

  • Line 4, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'The BackdropBlurBrush is a Brush that blurs whatever is behind it in the application.' is duplicated in 'brushes/BackdropBlurBrush.md(4,14)', 'brushes/BackdropGammaTransferBrush.md(4,14)'.

docs/brushes/BackdropGammaTransferBrush.md

  • Line 4, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'The BackdropBlurBrush is a Brush that blurs whatever is behind it in the application.' is duplicated in 'brushes/BackdropBlurBrush.md(4,14)', 'brushes/BackdropGammaTransferBrush.md(4,14)'.

docs/controls/wpf-winforms/WebView.md

  • Line 547, Column 60: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.

docs/controls/wpf-winforms/WebViewCompatible.md

  • Line 20, Column 53: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.
  • Line 23, Column 156: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.
  • Line 35, Column 692: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.
  • Line 53, Column 528: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld30
Copy link

opbld30 commented Mar 7, 2021

Docs Build status updates of commit e174fdd:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/controls/datagrid_guidance/editing_inputvalidation.md ⚠️Warning View Details
docs/controls/datagrid_guidance/keyboard_navigation_selection.md ⚠️Warning View Details
docs/controls/datagrid_guidance/rowdetails.md ⚠️Warning View Details
docs/controls/datagrid_guidance/styling_formatting_options.md ⚠️Warning View Details
docs/extensions/ScrollViewerExtensions.md ⚠️Warning View Details
docs/brushes/BackdropBlurBrush.md 💡Suggestion View Details
docs/brushes/BackdropGammaTransferBrush.md 💡Suggestion View Details
docs/controls/wpf-winforms/WebView.md 💡Suggestion View Details
docs/controls/wpf-winforms/WebViewCompatible.md 💡Suggestion View Details
docs/animations/AnimationBuilder.md ✅Succeeded View
docs/animations/AnimationSet.md ✅Succeeded View
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/ImplicitAnimationSet.md ✅Succeeded View
docs/animations/ImplicitAnimations.md ✅Succeeded View
docs/animations/ItemsReorderAnimation.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View
docs/brushes/AcrylicBrush.md ✅Succeeded View
docs/brushes/BackdropInvertBrush.md ✅Succeeded View
docs/brushes/BackdropSaturationBrush.md ✅Succeeded View
docs/brushes/BackdropSepiaBrush.md ✅Succeeded View
docs/brushes/ImageBlendBrush.md ✅Succeeded View
docs/brushes/PipelineBrush.md ✅Succeeded View
docs/brushes/RadialGradientBrush.md ✅Succeeded View
docs/brushes/TilesBrush.md ✅Succeeded View
docs/controls/datagrid_guidance/customize_autogenerated_columns.md ✅Succeeded View
docs/controls/datagrid_guidance/datagrid_basics.md ✅Succeeded View
docs/controls/datagrid_guidance/group_sort_filter.md ✅Succeeded View
docs/extensions/IconMarkupExtensions.md ✅Succeeded View
docs/gaze/GazeInteractionLibrary.md ✅Succeeded View
docs/helpers/Triggers.md ✅Succeeded View
docs/resources/images/AnimationSet.gif ✅Succeeded View
docs/resources/images/EffectAnimations.gif ✅Succeeded View
docs/resources/images/ImplicitAnimationSet.gif ✅Succeeded View
docs/toc.md ✅Succeeded View

docs/controls/datagrid_guidance/editing_inputvalidation.md

  • Line 18, Column 1: [Warning-alt-text-bad-value] Alt text 'Editing' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
  • Line 54, Column 1: [Warning-alt-text-bad-value] Alt text 'Validation' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/controls/datagrid_guidance/keyboard_navigation_selection.md

  • Line 57, Column 1: [Warning-alt-text-bad-value] Alt text 'Selection' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/controls/datagrid_guidance/rowdetails.md

  • Line 12, Column 1: [Warning-alt-text-bad-value] Alt text 'RowDetails' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/controls/datagrid_guidance/styling_formatting_options.md

  • Line 26, Column 1: [Warning-alt-text-bad-value] Alt text 'Gridlines' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
  • Line 99, Column 1: [Warning-alt-text-bad-value] Alt text 'FrozenColumns' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
  • Line 112, Column 1: [Warning-alt-text-bad-value] Alt text 'ResizeColumns' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/extensions/ScrollViewerExtensions.md

  • Line 102, Column 1: [Warning-alt-text-bad-value] Alt text 'MiddleClickScrolling' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/brushes/BackdropBlurBrush.md

  • Line 4, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'The BackdropBlurBrush is a Brush that blurs whatever is behind it in the application.' is duplicated in 'brushes/BackdropBlurBrush.md(4,14)', 'brushes/BackdropGammaTransferBrush.md(4,14)'.

docs/brushes/BackdropGammaTransferBrush.md

  • Line 4, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'The BackdropBlurBrush is a Brush that blurs whatever is behind it in the application.' is duplicated in 'brushes/BackdropBlurBrush.md(4,14)', 'brushes/BackdropGammaTransferBrush.md(4,14)'.

docs/controls/wpf-winforms/WebView.md

  • Line 547, Column 60: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.

docs/controls/wpf-winforms/WebViewCompatible.md

  • Line 20, Column 53: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.
  • Line 23, Column 156: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.
  • Line 35, Column 692: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.
  • Line 53, Column 528: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Sergio0694 Sergio0694 force-pushed the feature/animations-revamp branch from e174fdd to 4ef15b0 Compare March 7, 2021 22:49
@opbld33
Copy link

opbld33 commented Mar 7, 2021

Docs Build status updates of commit 4ef15b0:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/AnimationBuilder.md ✅Succeeded View
docs/animations/AnimationSet.md ✅Succeeded View
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/ImplicitAnimationSet.md ✅Succeeded View
docs/animations/ImplicitAnimations.md ✅Succeeded View
docs/animations/ItemsReorderAnimation.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View
docs/brushes/AcrylicBrush.md ✅Succeeded View
docs/brushes/BackdropBlurBrush.md ✅Succeeded View
docs/brushes/BackdropGammaTransferBrush.md ✅Succeeded View
docs/brushes/BackdropInvertBrush.md ✅Succeeded View
docs/brushes/BackdropSaturationBrush.md ✅Succeeded View
docs/brushes/BackdropSepiaBrush.md ✅Succeeded View
docs/brushes/ImageBlendBrush.md ✅Succeeded View
docs/brushes/PipelineBrush.md ✅Succeeded View
docs/brushes/RadialGradientBrush.md ✅Succeeded View
docs/brushes/TilesBrush.md ✅Succeeded View
docs/controls/datagrid_guidance/customize_autogenerated_columns.md ✅Succeeded View
docs/controls/datagrid_guidance/datagrid_basics.md ✅Succeeded View
docs/controls/datagrid_guidance/editing_inputvalidation.md ✅Succeeded View
docs/controls/datagrid_guidance/group_sort_filter.md ✅Succeeded View
docs/controls/datagrid_guidance/keyboard_navigation_selection.md ✅Succeeded View
docs/controls/datagrid_guidance/rowdetails.md ✅Succeeded View
docs/controls/datagrid_guidance/styling_formatting_options.md ✅Succeeded View
docs/controls/wpf-winforms/WebView.md ✅Succeeded View
docs/controls/wpf-winforms/WebViewCompatible.md ✅Succeeded View
docs/extensions/IconMarkupExtensions.md ✅Succeeded View
docs/extensions/ScrollViewerExtensions.md ✅Succeeded View
docs/gaze/GazeInteractionLibrary.md ✅Succeeded View
docs/helpers/Triggers.md ✅Succeeded View
docs/resources/images/AnimationSet.gif ✅Succeeded View
docs/resources/images/EffectAnimations.gif ✅Succeeded View
docs/resources/images/ImplicitAnimationSet.gif ✅Succeeded View
docs/toc.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Sergio0694 Sergio0694 force-pushed the feature/animations-revamp branch from 4ef15b0 to 85ed857 Compare March 7, 2021 22:57
@Sergio0694
Copy link
Contributor Author

@michael-hawker Done! 😄

@opbld32
Copy link

opbld32 commented Mar 7, 2021

Docs Build status updates of commit 85ed857:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/AnimationBuilder.md ✅Succeeded View
docs/animations/AnimationSet.md ✅Succeeded View
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/ImplicitAnimationSet.md ✅Succeeded View
docs/animations/ImplicitAnimations.md ✅Succeeded View
docs/animations/ItemsReorderAnimation.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View
docs/brushes/AcrylicBrush.md ✅Succeeded View
docs/brushes/BackdropBlurBrush.md ✅Succeeded View
docs/brushes/BackdropGammaTransferBrush.md ✅Succeeded View
docs/brushes/BackdropInvertBrush.md ✅Succeeded View
docs/brushes/BackdropSaturationBrush.md ✅Succeeded View
docs/brushes/BackdropSepiaBrush.md ✅Succeeded View
docs/brushes/ImageBlendBrush.md ✅Succeeded View
docs/brushes/PipelineBrush.md ✅Succeeded View
docs/brushes/RadialGradientBrush.md ✅Succeeded View
docs/brushes/TilesBrush.md ✅Succeeded View
docs/controls/datagrid_guidance/customize_autogenerated_columns.md ✅Succeeded View
docs/controls/datagrid_guidance/datagrid_basics.md ✅Succeeded View
docs/controls/datagrid_guidance/editing_inputvalidation.md ✅Succeeded View
docs/controls/datagrid_guidance/group_sort_filter.md ✅Succeeded View
docs/controls/datagrid_guidance/keyboard_navigation_selection.md ✅Succeeded View
docs/controls/datagrid_guidance/rowdetails.md ✅Succeeded View
docs/controls/datagrid_guidance/styling_formatting_options.md ✅Succeeded View
docs/controls/wpf-winforms/WebView.md ✅Succeeded View
docs/controls/wpf-winforms/WebViewCompatible.md ✅Succeeded View
docs/extensions/IconMarkupExtensions.md ✅Succeeded View
docs/extensions/ScrollViewerExtensions.md ✅Succeeded View
docs/gaze/GazeInteractionLibrary.md ✅Succeeded View
docs/helpers/Triggers.md ✅Succeeded View
docs/resources/images/AnimationSet.gif ✅Succeeded View
docs/resources/images/EffectAnimations.gif ✅Succeeded View
docs/resources/images/ImplicitAnimationSet.gif ✅Succeeded View
docs/toc.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@michael-hawker
Copy link
Collaborator

@Sergio0694 should we use the new GIFs here? Also conflict now, so think once we tweak that we're good?

@michael-hawker michael-hawker added this to the 7.0 milestone Mar 8, 2021
@Sergio0694 Sergio0694 force-pushed the feature/animations-revamp branch from 85ed857 to c4042bb Compare March 8, 2021 20:56
@opbld33
Copy link

opbld33 commented Mar 8, 2021

Docs Build status updates of commit c4042bb:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/AnimationBuilder.md ✅Succeeded View
docs/animations/AnimationSet.md ✅Succeeded View
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/ImplicitAnimationSet.md ✅Succeeded View
docs/animations/ImplicitAnimations.md ✅Succeeded View
docs/animations/ItemsReorderAnimation.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View
docs/brushes/AcrylicBrush.md ✅Succeeded View
docs/brushes/BackdropBlurBrush.md ✅Succeeded View
docs/brushes/BackdropGammaTransferBrush.md ✅Succeeded View
docs/brushes/BackdropInvertBrush.md ✅Succeeded View
docs/brushes/BackdropSaturationBrush.md ✅Succeeded View
docs/brushes/BackdropSepiaBrush.md ✅Succeeded View
docs/brushes/ImageBlendBrush.md ✅Succeeded View
docs/brushes/PipelineBrush.md ✅Succeeded View
docs/brushes/RadialGradientBrush.md ✅Succeeded View
docs/brushes/TilesBrush.md ✅Succeeded View
docs/controls/datagrid_guidance/customize_autogenerated_columns.md ✅Succeeded View
docs/controls/datagrid_guidance/datagrid_basics.md ✅Succeeded View
docs/controls/datagrid_guidance/editing_inputvalidation.md ✅Succeeded View
docs/controls/datagrid_guidance/group_sort_filter.md ✅Succeeded View
docs/controls/datagrid_guidance/keyboard_navigation_selection.md ✅Succeeded View
docs/controls/datagrid_guidance/rowdetails.md ✅Succeeded View
docs/controls/datagrid_guidance/styling_formatting_options.md ✅Succeeded View
docs/controls/wpf-winforms/WebView.md ✅Succeeded View
docs/controls/wpf-winforms/WebViewCompatible.md ✅Succeeded View
docs/extensions/IconMarkupExtensions.md ✅Succeeded View
docs/extensions/ScrollViewerExtensions.md ✅Succeeded View
docs/gaze/GazeInteractionLibrary.md ✅Succeeded View
docs/helpers/Triggers.md ✅Succeeded View
docs/resources/images/AnimationSet.gif ✅Succeeded View
docs/resources/images/EffectAnimations.gif ✅Succeeded View
docs/resources/images/ImplicitAnimationSet.gif ✅Succeeded View
docs/toc.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31
Copy link

opbld31 commented Mar 8, 2021

Docs Build status updates of commit 6ddca69:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/AnimationBuilder.md ✅Succeeded View
docs/animations/AnimationSet.md ✅Succeeded View
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/ImplicitAnimationSet.md ✅Succeeded View
docs/animations/ImplicitAnimations.md ✅Succeeded View
docs/animations/ItemsReorderAnimation.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View
docs/brushes/AcrylicBrush.md ✅Succeeded View
docs/brushes/BackdropBlurBrush.md ✅Succeeded View
docs/brushes/BackdropGammaTransferBrush.md ✅Succeeded View
docs/brushes/BackdropInvertBrush.md ✅Succeeded View
docs/brushes/BackdropSaturationBrush.md ✅Succeeded View
docs/brushes/BackdropSepiaBrush.md ✅Succeeded View
docs/brushes/ImageBlendBrush.md ✅Succeeded View
docs/brushes/PipelineBrush.md ✅Succeeded View
docs/brushes/RadialGradientBrush.md ✅Succeeded View
docs/brushes/TilesBrush.md ✅Succeeded View
docs/controls/datagrid_guidance/customize_autogenerated_columns.md ✅Succeeded View
docs/controls/datagrid_guidance/datagrid_basics.md ✅Succeeded View
docs/controls/datagrid_guidance/editing_inputvalidation.md ✅Succeeded View
docs/controls/datagrid_guidance/group_sort_filter.md ✅Succeeded View
docs/controls/datagrid_guidance/keyboard_navigation_selection.md ✅Succeeded View
docs/controls/datagrid_guidance/rowdetails.md ✅Succeeded View
docs/controls/datagrid_guidance/styling_formatting_options.md ✅Succeeded View
docs/controls/wpf-winforms/WebView.md ✅Succeeded View
docs/controls/wpf-winforms/WebViewCompatible.md ✅Succeeded View
docs/extensions/IconMarkupExtensions.md ✅Succeeded View
docs/extensions/ScrollViewerExtensions.md ✅Succeeded View
docs/gaze/GazeInteractionLibrary.md ✅Succeeded View
docs/helpers/Triggers.md ✅Succeeded View
docs/resources/images/AnimationSet.gif ✅Succeeded View
docs/resources/images/EffectAnimations.gif ✅Succeeded View
docs/resources/images/ImplicitAnimationSet.gif ✅Succeeded View
docs/toc.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Sergio0694 Sergio0694 force-pushed the feature/animations-revamp branch from 6ddca69 to 75f25e2 Compare March 8, 2021 21:02
@opbld30
Copy link

opbld30 commented Mar 8, 2021

Docs Build status updates of commit 75f25e2:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/AnimationBuilder.md ✅Succeeded View
docs/animations/AnimationSet.md ✅Succeeded View
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/ImplicitAnimationSet.md ✅Succeeded View
docs/animations/ImplicitAnimations.md ✅Succeeded View
docs/animations/ItemsReorderAnimation.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View
docs/brushes/AcrylicBrush.md ✅Succeeded View
docs/brushes/BackdropBlurBrush.md ✅Succeeded View
docs/brushes/BackdropGammaTransferBrush.md ✅Succeeded View
docs/brushes/BackdropInvertBrush.md ✅Succeeded View
docs/brushes/BackdropSaturationBrush.md ✅Succeeded View
docs/brushes/BackdropSepiaBrush.md ✅Succeeded View
docs/brushes/ImageBlendBrush.md ✅Succeeded View
docs/brushes/PipelineBrush.md ✅Succeeded View
docs/brushes/RadialGradientBrush.md ✅Succeeded View
docs/brushes/TilesBrush.md ✅Succeeded View
docs/controls/datagrid_guidance/customize_autogenerated_columns.md ✅Succeeded View
docs/controls/datagrid_guidance/datagrid_basics.md ✅Succeeded View
docs/controls/datagrid_guidance/editing_inputvalidation.md ✅Succeeded View
docs/controls/datagrid_guidance/group_sort_filter.md ✅Succeeded View
docs/controls/datagrid_guidance/keyboard_navigation_selection.md ✅Succeeded View
docs/controls/datagrid_guidance/rowdetails.md ✅Succeeded View
docs/controls/datagrid_guidance/styling_formatting_options.md ✅Succeeded View
docs/controls/wpf-winforms/WebView.md ✅Succeeded View
docs/controls/wpf-winforms/WebViewCompatible.md ✅Succeeded View
docs/extensions/IconMarkupExtensions.md ✅Succeeded View
docs/extensions/ScrollViewerExtensions.md ✅Succeeded View
docs/gaze/GazeInteractionLibrary.md ✅Succeeded View
docs/helpers/Triggers.md ✅Succeeded View
docs/resources/images/AnimationSet.gif ✅Succeeded View
docs/resources/images/EffectAnimations.gif ✅Succeeded View
docs/resources/images/ImplicitAnimationSet.gif ✅Succeeded View
docs/toc.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Mar 8, 2021

Docs Build status updates of commit 733c200:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/AnimationBuilder.md ✅Succeeded View
docs/animations/AnimationSet.md ✅Succeeded View
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/ImplicitAnimationSet.md ✅Succeeded View
docs/animations/ImplicitAnimations.md ✅Succeeded View
docs/animations/ItemsReorderAnimation.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View
docs/brushes/AcrylicBrush.md ✅Succeeded View
docs/brushes/BackdropBlurBrush.md ✅Succeeded View
docs/brushes/BackdropGammaTransferBrush.md ✅Succeeded View
docs/brushes/BackdropInvertBrush.md ✅Succeeded View
docs/brushes/BackdropSaturationBrush.md ✅Succeeded View
docs/brushes/BackdropSepiaBrush.md ✅Succeeded View
docs/brushes/ImageBlendBrush.md ✅Succeeded View
docs/brushes/PipelineBrush.md ✅Succeeded View
docs/brushes/RadialGradientBrush.md ✅Succeeded View
docs/brushes/TilesBrush.md ✅Succeeded View
docs/controls/datagrid_guidance/customize_autogenerated_columns.md ✅Succeeded View
docs/controls/datagrid_guidance/datagrid_basics.md ✅Succeeded View
docs/controls/datagrid_guidance/editing_inputvalidation.md ✅Succeeded View
docs/controls/datagrid_guidance/group_sort_filter.md ✅Succeeded View
docs/controls/datagrid_guidance/keyboard_navigation_selection.md ✅Succeeded View
docs/controls/datagrid_guidance/rowdetails.md ✅Succeeded View
docs/controls/datagrid_guidance/styling_formatting_options.md ✅Succeeded View
docs/controls/wpf-winforms/WebView.md ✅Succeeded View
docs/controls/wpf-winforms/WebViewCompatible.md ✅Succeeded View
docs/extensions/IconMarkupExtensions.md ✅Succeeded View
docs/extensions/ScrollViewerExtensions.md ✅Succeeded View
docs/gaze/GazeInteractionLibrary.md ✅Succeeded View
docs/helpers/Triggers.md ✅Succeeded View
docs/resources/images/AnimationSet.gif ✅Succeeded View
docs/resources/images/EffectAnimations.gif ✅Succeeded View
docs/resources/images/ImplicitAnimationSet.gif ✅Succeeded View
docs/toc.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@michael-hawker michael-hawker merged commit 95fc67f into MicrosoftDocs:master Mar 8, 2021
@Sergio0694 Sergio0694 mentioned this pull request Apr 20, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

+1 more reviewer

@Kyaa-dost Kyaa-dost Kyaa-dost approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assigned-to-author 🚀 doc-provided ✔️ Ready to Merge 🚀

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Sergio0694 @opbld31 @michael-hawker @opbld30 @opbld33 @opbld32 @Kyaa-dost