- 
                Notifications
    You must be signed in to change notification settings 
- Fork 156
FontIconExtension, FontIconSourceExtension, BitmapExtension #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FontIconExtension, FontIconSourceExtension, BitmapExtension #313
Conversation
| Docs Build status updates of commit 9beeb35: ✅ Validation status: passed
 For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. | 
| @Sergio0694 do we want to just call this page 'IconMarkupExtensions'? Maybe we can have a central header and a little intro blurb about the overall category? | 
| Sure thing! I'll rename the page and try to come up with a brief introduction then 😊 | 
| Docs Build status updates of commit 2853fd6: ✅ Validation status: passed
 For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. | 
| Docs Build status updates of commit 792ff26: ✅ Validation status: passed
 For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. | 
Co-authored-by: Kyaa-dost <35208324+Kyaa-dost@users.noreply.github.com>
| Docs Build status updates of commit 2fa7f2b: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue. dotnet/api/Microsoft.Toolkit.Uwp.UI.Animations.Behaviors.QuickReturnHeaderBehavior.yml
 dotnet/api/Microsoft.Toolkit.Uwp.UI.Controls.RadialGauge.yml
 dotnet/api/Microsoft.Toolkit.Uwp.UI.Controls.TabClosingEventArgs.yml
 dotnet/api/Microsoft.Toolkit.Uwp.UI.Animations.Behaviors.StickyHeaderBehavior.yml
 dotnet/api/Microsoft.Toolkit.Uwp.UI.Animations.Behaviors.CompositionBehaviorBase-1.yml
 dotnet/api/Microsoft.Toolkit.Uwp.UI.Animations.Behaviors.FadeHeaderBehavior.yml
 For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please: 
 | 
| @Sergio0694 this one seems to be failing too. Try updating the changes from master into your own branch. | 
| Docs Build status updates of commit ff1b8a8: ✅ Validation status: passed
 For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please: 
 | 
| Docs Build status updates of commit 2fcffe9: ✅ Validation status: passed
 For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please: 
 | 
| Docs Build status updates of commit 1e23852: ✅ Validation status: passed
 For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please: 
 | 
| Docs Build status updates of commit 38c86b2: ✅ Validation status: passed
 For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please: 
 | 
| Docs Build status updates of commit 8e59d8b: ✅ Validation status: passed
 For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please: 
 | 
| Docs Build status updates of commit 0dffaa7: ✅ Validation status: passed
 For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please: 
 | 
| Docs Build status updates of commit ca78ee4: ✅ Validation status: passed
 For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please: 
 | 
| Docs Build status updates of commit 5fcc9f8: ✅ Validation status: passed
 For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please: 
 | 
| Docs Build status updates of commit 6c1ddba: ✅ Validation status: passed
 For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please: 
 | 
| | MirroredWhenRightToLeft | bool | Indicates whether the icon is mirrored when the flow direction is right to left. | | ||
|  | ||
| ## Requirements | ||
|  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be a good place to call out the WUX vs MUX compatibility? or up in the intro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the note in 316c99e, is this alright?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sergio0694 looks good. Think we should call out our WinUI 3 preview as then it doesn't matter? We could link to https://aka.ms/wct-winui3. As otherwise I don't think we'll support this scenario until then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That links only refers me to www.microsoft.com, is that aka not active yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo (missing i): https://aka.ms/wct-winui3
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
| Docs Build status updates of commit 4b1ea4b: ✅ Validation status: passed
 For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please: 
 | 
| Docs Build status updates of commit 316c99e: ✅ Validation status: passed
 For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please: 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting all the changes in @Sergio0694! 🎉🎉🎉
This PR adds docs page(s) for APIs from the Guard APIs (#3110).