Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke test #275

Merged
merged 8 commits into from
Nov 19, 2019
Merged

Smoke test #275

merged 8 commits into from
Nov 19, 2019

Conversation

v-alje
Copy link
Collaborator

@v-alje v-alje commented Nov 14, 2019

No description provided.

@opbld34
Copy link

opbld34 commented Nov 14, 2019

Docs Build status updates of commit 3e45559:

⚠️ Validation status: warnings

File Status Preview URL Details
dotnet/api/Microsoft.Toolkit.Win32.UI.XamlHost.XamlApplication.WindowsXamlManager.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Win32.UI.XamlHost.XamlApplication.IsDisposed.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Uwp.UI.Behaviors.ViewportBehavior.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Uwp.UI.Behaviors.ViewportBehavior.OnDetaching.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Uwp.UI.Behaviors.ViewportBehavior.OnAttached.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Graph.Extensions.GraphExtensions.ToPerson.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Graph.Extensions.GraphExtensions.FindPersonAsync.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Uwp.Input.GazeInteraction.GazePointer.CursorElement.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Uwp.UI.Behaviors.BehaviorBase-1.OnDetaching.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Uwp.UI.Behaviors.BehaviorBase-1.OnAttached.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Graph.Extensions.GraphExtensions.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Graph.Providers.MockProviderBehavior.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Graph.Controls.PeoplePicker.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Uwp.UI.Behaviors.BehaviorBase-1.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Graph.Providers.InteractiveProviderBehavior.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Graph.Providers.CommonProviderBehaviorBase.yml ⚠️Warning View Details
dotnet/api/Microsoft.Toolkit.Graph.Controls.yml ⚠️Warning View Details
dotnet/xml/FrameworksIndex/win-comm-toolkit-dotnet-stable.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Collections/IIncrementalSource`1.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Extensions/ArrayExtensions.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Extensions/StringExtensions.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/IWebViewCompatibleAdapter.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/InkCanvas.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/InkToolbar.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/InkToolbarCustomPenButton.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/InkToolbarCustomToolButton.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/InkToolbarIsStencilButtonCheckedChangedEventArgs.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/InkToolbarMenuButton.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/InkToolbarPenButton.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/InkToolbarStencilButton.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/InkToolbarToggleButton.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/InkToolbarToolButton.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/MapControl.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/MediaPlayerElement.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/WebView.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.Controls/WebViewCompatible.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.XamlHost/WindowsXamlHost.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.XamlHost/WindowsXamlHostBase.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Forms.UI.XamlHost/WrapperLookup.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Graph.Controls.Microsoft_Toolkit_Graph_Controls_XamlTypeInfo/XamlMetaDataProvider.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Graph.Controls/LoginButton.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Graph.Controls/LoginFailedEventArgs.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Graph.Controls/PeoplePicker.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Graph.Controls/PersonView.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Graph.Converters/UserToPersonConverter.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Graph.Extensions/GraphExtensions.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Graph.Providers/CommonProviderBehaviorBase.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Graph.Providers/IProvider.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Graph.Providers/InteractiveProviderBehavior.xml ✅Succeeded
dotnet/xml/Microsoft.Toolkit.Graph.Providers/MockProvider.xml ✅Succeeded

This comment lists only the first 50 files in the pull request.

dotnet/api/Microsoft.Toolkit.Win32.UI.XamlHost.XamlApplication.WindowsXamlManager.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Toolkit.Win32.UI.XamlHost.IXamlApplication.WindowsXamlManager".

dotnet/api/Microsoft.Toolkit.Win32.UI.XamlHost.XamlApplication.IsDisposed.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Toolkit.Win32.UI.XamlHost.IXamlApplication.IsDisposed".

dotnet/api/Microsoft.Toolkit.Uwp.UI.Behaviors.ViewportBehavior.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Xaml.Interactivity.Behavior.AssociatedObject".

dotnet/api/Microsoft.Toolkit.Uwp.UI.Behaviors.ViewportBehavior.OnDetaching.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Xaml.Interactivity.Behavior.AssociatedObject".

dotnet/api/Microsoft.Toolkit.Uwp.UI.Behaviors.ViewportBehavior.OnAttached.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Xaml.Interactivity.Behavior.AssociatedObject".

dotnet/api/Microsoft.Toolkit.Graph.Extensions.GraphExtensions.ToPerson.yml

  • [Warning] 5 invalid cross reference(s) "Microsoft.Graph.Entity.Id", "Microsoft.Graph.User.DisplayName", "Microsoft.Graph.Person.EmailAddresses", "Microsoft.Graph.User.GivenName", "Microsoft.Graph.User.Surname".

dotnet/api/Microsoft.Toolkit.Graph.Extensions.GraphExtensions.FindPersonAsync.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Graph.IUserPeopleCollectionPage".

dotnet/api/Microsoft.Toolkit.Uwp.Input.GazeInteraction.GazePointer.CursorElement.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Toolkit.Uwp.Input.GazeInteraction.__IGazePointerPublicNonVirtuals.CursorElement".

dotnet/api/Microsoft.Toolkit.Uwp.UI.Behaviors.BehaviorBase-1.OnDetaching.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Xaml.Interactivity.Behavior.AssociatedObject".

dotnet/api/Microsoft.Toolkit.Uwp.UI.Behaviors.BehaviorBase-1.OnAttached.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Xaml.Interactivity.Behavior.AssociatedObject".

dotnet/api/Microsoft.Toolkit.Graph.Extensions.GraphExtensions.yml

  • [Warning] 5 invalid cross reference(s) "Microsoft.Graph.Entity.Id", "Microsoft.Graph.User.DisplayName", "Microsoft.Graph.Person.EmailAddresses", "Microsoft.Graph.User.GivenName", "Microsoft.Graph.User.Surname".

dotnet/api/Microsoft.Toolkit.Graph.Providers.MockProviderBehavior.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Xaml.Interactivity.Behavior.AssociatedObject".

dotnet/api/Microsoft.Toolkit.Graph.Controls.PeoplePicker.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Toolkit.Uwp.UI.Controls.TokenizingTextBox".

dotnet/api/Microsoft.Toolkit.Uwp.UI.Behaviors.BehaviorBase-1.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Xaml.Interactivity.Behavior.AssociatedObject".

dotnet/api/Microsoft.Toolkit.Graph.Providers.InteractiveProviderBehavior.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Xaml.Interactivity.Behavior.AssociatedObject".

dotnet/api/Microsoft.Toolkit.Graph.Providers.CommonProviderBehaviorBase.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Xaml.Interactivity.Behavior.AssociatedObject".

dotnet/api/Microsoft.Toolkit.Graph.Controls.yml

  • [Warning] 1 invalid cross reference(s) "Microsoft.Toolkit.Uwp.UI.Controls.TokenizingTextBox".

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@michael-hawker
Copy link
Collaborator

Thanks @v-alje, is this all set to go? The spot checks I did looked good.

Do we have to worry about the warnings above at all?

@v-alje
Copy link
Collaborator Author

v-alje commented Nov 19, 2019

@michael-hawker Those invalid cross references are type reference links in the the source XML that point to objects that don't exist on Docs. Either because they are private, or have not been added somewhere.
They shouldn't block publishing. The links to the objects will just come out as plain text.

@v-alje v-alje merged commit 86b4a8b into master Nov 19, 2019
@v-alje v-alje deleted the smoke-test branch November 19, 2019 21:43
@michael-hawker
Copy link
Collaborator

Thanks @v-alje. Sounds like something we need to fix in the documentation comments in our main repo then. I think some of these are from preview/obsolete things, so maybe they'll get resolved in the next release, but I'll add an item tracking it in the main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants