-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Get-Item -stream now works on directories. (PS #13941) #6648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Docs Build status updates of commit 7e2fca9: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 29c65db: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Updated the PR that this should be waiting on, now PowerShell/PowerShell#13941. |
@kyanha Your code PR has been merged. But the change affects more than just |
Docs Build status updates of commit 9baee28: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 64d71bc: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
None of the documentation for the other cmdlets involved stated that -Stream could only target files, not directories. Get-Content was the only one that did. Accordingly, I didn't think that any changes were necessary for the remaining documentation to be correct. I have updated all six with the version changelog. Note that the -Stream parameter isn't even recognized on non-Windows systems. Note that PR PowerShell/13941 was accepted into PowerShell 7.2, not 7.1. I'm not sure what to do about that, since there is no |
Hey @kyanha, with the release of PowerShell 7.2, Sean added the files for 7.2. Have you rebased in the last bit? |
I did a git fetch and git pull from origin last night, and I didn't get any
updates. When did these changes happen?
…On Fri, Dec 18, 2020 at 12:32 PM Chase Wilson ***@***.***> wrote:
Hey @kyanha <https://github.com/kyanha>, with the release of PowerShell
7.2, Sean added the files for 7.2. Have you rebased in the last bit?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6648 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMMFL3TYCUB5PA563GG5LSVON4FANCNFSM4RRSDP2Q>
.
|
A while back. You might need to run the following: git checkout staging
git fetch upstream staging
git pull upstream staging
git push
git checkout kyanha:ps10570
git rebase staging This might be a bit overkill but I do it just to keep all my stuff current every once in a while. The origin branch is just your forked repo and needs to be rebased (synced) with the history of the Upstream (Microsoft Docs) repo. Let me know if you have any issues with this |
I'm trying, and I can't figure out the git commands to make it happen. I'm giving up on doing so. I'm certain you have more knowledge, capacity, and patience to fight with this than I do, particularly since you're actually getting paid to do this. I've fought for over two months now to get this completed and landed, and I don't have the patience anymore. |
@kyanha I'm sorry you are frustrated. I'll go ahead and create a new PR if you don't mind then and link and credit you in there if you don't have an issue with that course of action? The contribution is really appreciated and I'm sorry the process has been a struggle. If you have any questions or want to go through the git process some, let me know. I know how confusing it can be and have been on the frustrating end of things more than once. |
Going to close this PR due to finishing it here. Thanks again! |
PR Summary
Modified for Powershell 7.1 (but is actually related to Powershell 7.2, since the PR didn't get into Powershell for 7.1), relates to PowerShell/PowerShell#13941, to document Get-Item -stream now working for directories.
PowerShell Pull Request
PR Context
Select the area of the Table of Contents containing the documents being changed.
Conceptual content
Cmdlet reference & about_ topics
PR Checklist
WIP:
or[WIP]
to the beginning of thetitle and remove the prefix when the PR is ready.