Skip to content

Get-Item -stream now works on directories. (PS #13941) #6648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

kyanha
Copy link

@kyanha kyanha commented Sep 18, 2020

PR Summary

Modified for Powershell 7.1 (but is actually related to Powershell 7.2, since the PR didn't get into Powershell for 7.1), relates to PowerShell/PowerShell#13941, to document Get-Item -stream now working for directories.

PowerShell Pull Request

PR Context

Select the area of the Table of Contents containing the documents being changed.

Conceptual content

  • Overview and Install
  • Learning PowerShell
    • PowerShell 101
    • Deep dives
    • Remoting
  • Release notes (What's New)
  • Windows PowerShell
    • WMF, ISE, release notes, etc.
  • DSC articles
  • Community resources
  • Sample scripts
  • Gallery articles
  • Scripting and development
    • Legacy SDK

Cmdlet reference & about_ topics

  • Version 7.1 preview content
  • Version 7.0 content
  • Version 6 content
  • Version 5.1 content

PR Checklist

  • I have read the contributors guide and followed the style and process guidelines
  • PR has a meaningful title
  • PR is targeted at the staging branch
  • All relevant versions updated
  • Includes content related to issues and PRs - see Closing issues using keywords.
  • This PR is ready to merge and is not Work in Progress
    • If the PR is work in progress, please add the prefix WIP: or [WIP] to the beginning of the
      title and remove the prefix when the PR is ready.

@opbld30
Copy link

opbld30 commented Sep 18, 2020

Docs Build status updates of commit 7e2fca9:

✅ Validation status: passed

File Status Preview URL Details
reference/7.1/Microsoft.PowerShell.Management/Get-Item.md ✅Succeeded View (powershell-7.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@chasewilson chasewilson added the hold-for-pr Waiting - for PR merge label Sep 18, 2020
@opbld30
Copy link

opbld30 commented Sep 18, 2020

Docs Build status updates of commit 29c65db:

✅ Validation status: passed

File Status Preview URL Details
reference/7.1/Microsoft.PowerShell.Management/Get-Item.md ✅Succeeded View (powershell-7.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@kyanha kyanha changed the title Get-Item -stream now works on directories. (PS #10570) Get-Item -stream now works on directories. (PS #13941) Oct 31, 2020
@kyanha
Copy link
Author

kyanha commented Oct 31, 2020

Updated the PR that this should be waiting on, now PowerShell/PowerShell#13941.

@sdwheeler sdwheeler added needs-response Waiting - for response and removed hold-for-pr Waiting - for PR merge labels Dec 17, 2020
@sdwheeler
Copy link
Collaborator

@kyanha Your code PR has been merged. But the change affects more than just Get-Item. Can you update the docs for the other cmdlets.

@opbld31
Copy link

opbld31 commented Dec 18, 2020

Docs Build status updates of commit 9baee28:

✅ Validation status: passed

File Status Preview URL Details
reference/7.1/Microsoft.PowerShell.Management/Add-Content.md ✅Succeeded View (powershell-7.1)
reference/7.1/Microsoft.PowerShell.Management/Clear-Content.md ✅Succeeded View (powershell-7.1)
reference/7.1/Microsoft.PowerShell.Management/Get-Content.md ✅Succeeded View (powershell-7.1)
reference/7.1/Microsoft.PowerShell.Management/Get-Item.md ✅Succeeded View (powershell-7.1)
reference/7.1/Microsoft.PowerShell.Management/Remove-Item.md ✅Succeeded View (powershell-7.1)
reference/7.1/Microsoft.PowerShell.Management/Set-Content.md ✅Succeeded View (powershell-7.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link

opbld33 commented Dec 18, 2020

Docs Build status updates of commit 64d71bc:

✅ Validation status: passed

File Status Preview URL Details
reference/7.1/Microsoft.PowerShell.Management/Add-Content.md ✅Succeeded View (powershell-7.1)
reference/7.1/Microsoft.PowerShell.Management/Clear-Content.md ✅Succeeded View (powershell-7.1)
reference/7.1/Microsoft.PowerShell.Management/Get-Content.md ✅Succeeded View (powershell-7.1)
reference/7.1/Microsoft.PowerShell.Management/Get-Item.md ✅Succeeded View (powershell-7.1)
reference/7.1/Microsoft.PowerShell.Management/Remove-Item.md ✅Succeeded View (powershell-7.1)
reference/7.1/Microsoft.PowerShell.Management/Set-Content.md ✅Succeeded View (powershell-7.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@kyanha
Copy link
Author

kyanha commented Dec 18, 2020

None of the documentation for the other cmdlets involved stated that -Stream could only target files, not directories. Get-Content was the only one that did. Accordingly, I didn't think that any changes were necessary for the remaining documentation to be correct.

I have updated all six with the version changelog. Note that the -Stream parameter isn't even recognized on non-Windows systems.

Note that PR PowerShell/13941 was accepted into PowerShell 7.2, not 7.1. I'm not sure what to do about that, since there is no reference/7.2 directory.

@chasewilson
Copy link
Contributor

Hey @kyanha, with the release of PowerShell 7.2, Sean added the files for 7.2. Have you rebased in the last bit?

@kyanha
Copy link
Author

kyanha commented Dec 18, 2020 via email

@chasewilson
Copy link
Contributor

chasewilson commented Dec 18, 2020

A while back. You might need to run the following:

git checkout staging
git fetch upstream staging
git pull upstream staging
git push
git checkout kyanha:ps10570
git rebase staging

This might be a bit overkill but I do it just to keep all my stuff current every once in a while.

The origin branch is just your forked repo and needs to be rebased (synced) with the history of the Upstream (Microsoft Docs) repo.

Let me know if you have any issues with this

@kyanha
Copy link
Author

kyanha commented Dec 18, 2020

I'm trying, and I can't figure out the git commands to make it happen. I'm giving up on doing so. I'm certain you have more knowledge, capacity, and patience to fight with this than I do, particularly since you're actually getting paid to do this.

I've fought for over two months now to get this completed and landed, and I don't have the patience anymore.

@chasewilson
Copy link
Contributor

@kyanha I'm sorry you are frustrated. I'll go ahead and create a new PR if you don't mind then and link and credit you in there if you don't have an issue with that course of action?

The contribution is really appreciated and I'm sorry the process has been a struggle. If you have any questions or want to go through the git process some, let me know. I know how confusing it can be and have been on the frustrating end of things more than once.

@chasewilson
Copy link
Contributor

Going to close this PR due to finishing it here.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-response Waiting - for response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants