Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Key collision for test run parameters #328

Merged
merged 8 commits into from
Dec 6, 2017

Conversation

jayaranigarg
Copy link
Member

No description provided.

// Trigger another Run
this.TestExecutionManager.RunTests(tests, this.runContext, this.frameworkHandle, new TestRunCancellationToken());

CollectionAssert.Contains(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do String assert.

@jayaranigarg
Copy link
Member Author

#298

@jayaranigarg jayaranigarg deleted the keycollisionfix branch December 8, 2017 08:38
mayankbansal018 added a commit that referenced this pull request Apr 3, 2018
* Fixing Key collision for test run parameters (#328)

* Base commit

* Adding Unit Test

* PR comments

* Adding logs for diagnostics

* Ignoring Test Temporarily

* Removing ignore

# Conflicts:
#	test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestExecutionManagerTests.cs

* Fixing the copyright in the nuspec files. (#350)

* Today even if classInit wasnt called we used to call class cleanup. f… (#372)

* Today even if classInit wasnt called we used to call class cleanup. fixing that and adding a test to cover the scenario
# Conflicts:
#	src/Adapter/MSTest.CoreAdapter/Execution/TestClassInfo.cs

* [Symbol archiving]Converting Portable pdb to full (#375)

* COnverting portable pdbs to full for Symbol archiving

* Fixing nuget package path

* Test fix

* Indent fix

* Update Fileversion for adapter and framework dlls (#337)

* File version update

* Moving to 15.6

* PR comments

* More PR comments

* Throwing exception only if it is of type TestPlatformFormatException (#332)

* Throwing exception only if it is of type TestPlatformFormatException

* test

* Fail discovery if any exception thrown in IDiscoveryContext.GetTestCaseFilter

* Fix masking assembly load faolure error message (#382)


# Conflicts:
#	src/Adapter/MSTest.CoreAdapter/Discovery/AssemblyEnumeratorWrapper.cs
singhsarab pushed a commit to singhsarab/testfx that referenced this pull request Apr 8, 2019
Supporting Multiple TestProperty with the same key value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants