Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Luisgen readme #592

Merged
merged 6 commits into from
Oct 2, 2018
Merged

Luisgen readme #592

merged 6 commits into from
Oct 2, 2018

Conversation

chrimc62
Copy link
Contributor

@chrimc62 chrimc62 commented Sep 24, 2018

Fixes #

Proposed Changes

Restructure to better reflect the source code and build process for Visual Studio and Visual Studio Code.
Improve the readmes.
Added -v and --version to report the version.
Updated to 2.0.1.

@chrimc62 chrimc62 requested a review from tomlm September 24, 2018 23:39
break;
case "-v":
case "--version":
Console.WriteLine($"LUISGen version {System.Reflection.Assembly.GetExecutingAssembly().GetName().Version}");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right value?

Most people will have installed LuisGen via an NPM package that'll be versioned like "1.2.3". The assembly version is a quad, and will likley have a different number than the NPM package.

Is there a way to get the package from here?

@chrimc62 chrimc62 merged commit 93b363c into master Oct 2, 2018
@chrimc62 chrimc62 deleted the luisgen-readme branch October 2, 2018 00:32
@cleemullins
Copy link
Contributor

The build is failing with a really weird error. Is this something your code touched? It doesn't look like it to me. We should see if @johnataylor or @stevengum can take a look.

lerna notice cli v3.2.1
lerna info versioning independent
lerna ERR! npm run test exited 1 in 'undefined'
lerna ERR! npm run test stdout:
> @ test /home/travis/build/Microsoft/botbuilder-tools/packages/LUISGen
> dotnet test tests/LUISGenTest/LUISGenTest.csproj && cd tests/LUISGenTestJS/ && npm run build && npm run test
lerna ERR! npm run test stderr:
System.ArgumentException: Item has already been added. Key in dictionary: 'SPAWN_WRAP_SHIM_ROOT'  Key being added: 'SPAWN_WRAP_SHIM_ROOT'
   at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
   at System.Environment.ToHashtable(IEnumerable`1 pairs)
   at System.Environment.GetEnvironmentVariables()
   at System.Diagnostics.ProcessStartInfo.get_Environment()
   at Microsoft.DotNet.Cli.Utils.ForwardingAppImplementation.GetProcessStartInfo()
   at Microsoft.DotNet.Cli.Utils.MSBuildForwardingAppWithoutLogging.GetProcessStartInfo()
   at Microsoft.DotNet.Tools.MSBuild.MSBuildForwardingApp.GetProcessStartInfo()
   at Microsoft.DotNet.Tools.RestoringCommand.Execute()
   at Microsoft.DotNet.Tools.Test.TestCommand.Run(String[] args)
   at Microsoft.DotNet.Cli.Program.ProcessArgs(String[] args, ITelemetry telemetryClient)
   at Microsoft.DotNet.Cli.Program.Main(String[] args)

@stevengum
Copy link
Member

Crosslinking #621

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants