This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reogranize to better support new structure. Update readmes.
cleemullins
reviewed
Oct 1, 2018
break; | ||
case "-v": | ||
case "--version": | ||
Console.WriteLine($"LUISGen version {System.Reflection.Assembly.GetExecutingAssembly().GetName().Version}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right value?
Most people will have installed LuisGen via an NPM package that'll be versioned like "1.2.3". The assembly version is a quad, and will likley have a different number than the NPM package.
Is there a way to get the package from here?
cleemullins
approved these changes
Oct 1, 2018
The build is failing with a really weird error. Is this something your code touched? It doesn't look like it to me. We should see if @johnataylor or @stevengum can take a look.
|
Crosslinking #621 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Restructure to better reflect the source code and build process for Visual Studio and Visual Studio Code.
Improve the readmes.
Added -v and --version to report the version.
Updated to 2.0.1.