Skip to content

Fix build warnings #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix build warnings #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c457789
der: fix unwanted cast causing a build warning
joelguittet Oct 4, 2023
cf03b3b
cal_buffer: add missing include to provide support of printf
joelguittet Oct 4, 2023
b7bee91
hal_create_mutex: fix prototype of the function causing a build warning
joelguittet Oct 4, 2023
29d1e0d
add void to unused parameters causing a build warning
joelguittet Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/atca_iface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,7 @@ ATCA_STATUS ifacecfg_set_address(
ATCAKitType kitiface /**< [in] Optional parameter to set the kit iface type */
)
{
(void)kitiface;
ATCA_STATUS status = ATCA_BAD_PARAM;

if (NULL != cfg)
Expand Down
2 changes: 1 addition & 1 deletion lib/atcacert/atcacert_der.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ ATCA_STATUS atcacert_der_enc_length(size_t length, uint8_t* der_length, size_t*
der_length[0] = 0x80u | (uint8_t)(der_length_size_calc - 1u); // Set number of bytes octet with long-form flag

// Encode length in big-endian format
for (l_exp = 1; l_exp <= (int)der_length_size_calc; l_exp++)
for (l_exp = 1; l_exp <= der_length_size_calc; l_exp++)
{
#ifdef ATCA_PLATFORM_BE
der_length[exp] = len_bytes[sizeof(length) - *der_length_size + exp];
Expand Down
1 change: 1 addition & 0 deletions lib/cal_buffer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
* THIS SOFTWARE.
*/

#include <stdio.h>
#include <string.h>
#include "cal_buffer.h"

Expand Down
2 changes: 1 addition & 1 deletion lib/hal/hal_linux.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ ATCA_STATUS hal_unlock_mutex(void *pMutex)
* \param[in,out] ppMutex location to receive ptr to mutex
* \param[in,out] pName String used to identify the mutex
*/
ATCA_STATUS hal_create_mutex(void ** ppMutex, char* pName)
ATCA_STATUS hal_create_mutex(void ** ppMutex, const char* pName)
{
sem_t * sem;

Expand Down
2 changes: 1 addition & 1 deletion third_party/hal/zephyr/hal_zephyr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ void hal_delay_ms(uint32_t delay)
}


ATCA_STATUS hal_create_mutex(void ** ppMutex, char* pName)
ATCA_STATUS hal_create_mutex(void ** ppMutex, const char* pName)
{
(void)pName;

Expand Down
1 change: 1 addition & 0 deletions third_party/hal/zephyr/hal_zephyr_i2c.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ ATCA_STATUS hal_i2c_control(ATCAIface iface, uint8_t option, void* param, size_t

ATCA_STATUS hal_i2c_release(void *hal_data)
{
(void)hal_data;
return ATCA_SUCCESS;
}

Expand Down
1 change: 1 addition & 0 deletions third_party/hal/zephyr/hal_zephyr_spi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ ATCA_STATUS hal_spi_control(ATCAIface iface, uint8_t option, void* param, size_t
*/
ATCA_STATUS hal_spi_release(void *hal_data)
{
(void)hal_data;
return ATCA_SUCCESS;
}

Expand Down