pkcs11:avoid returning value overwriting #346
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuration(s) is incorrect, overwriting of returned value allows the init procedure to move forward instead of stopping. It triggers fails in later steps, which sometimes look not too much obvious. This change removes the rv value overwriting.
Here is an example. I pushed 2 configs which triggered an error.
Original version:
Modified version:
Checklist