The PKCS11 provider was not parsing properly the i2c dev entry from

[Irdroid]

The PKCS11 configuration. I am using ATECC608B, in Ubuntu, listed in sysfs as /dev/i2c-10 . When I change the configuration in /var/lib/cryptoauthlib/0.conf to point to i2c-10 device it compaints that it cant connect. It will only accept /dev/i2c-1 Thus this modification was needed!

Please describe the purpose of this pull request

Fix the issue with parsing the i2c dev number

Checklist

• I have reviewed the CONTRIBUTING.md and agree to it's terms

[bryan-hunt]

I'm rejecting this PR as having far too many problems to resolve:

1. atoi is unsafe and is prohibited by basically every C language coding standard - it has been deprecated and the correct function to use is strtol (which is what is being used in the line that you replaced). The configuration is expecting a hex value which since the other fields are represented in hex. Simply using the hex representation would have resolved your issue or else you could submit a request to document/change the representation. Just one of many examples of standards prohibiting it's use: https://wiki.sei.cmu.edu/confluence/display/c/MSC24-C.+Do+not+use+deprecated+or+obsolescent+functions

2. Pull requests should be logically separate into independent features/issues. Including a patch to resolve an ssh integration issue needs to be its own pull request. Atlassian Guide Github Guide

3. Don't run CMake in your source tree, use a build directory instead https://cmake.org/cmake/help/latest/manual/cmake.1.html#generate-a-project-buildsystem

4. Don't commit generated artifacts into source control

I would suggest opening an issue instead describing in detail the specific issue you are experiencing with ssh usage.