fix(winc): extract full DHCP configuration including subnet, gateway, and DNS #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and DNS The WINC driver's DHCP callback handler (M2M_WIFI_REQ_DHCP_CONF) was only extracting the IP address from the DHCP response, even though the WINC firmware provides complete network configuration in tstrM2MIPConfig. This fix properly casts the message to tstrM2MIPConfig* and extracts all network configuration fields: - IP address (u32StaticIP) - Subnet mask (u32SubnetMask) - Gateway (u32Gateway) - DNS server (u32DNS) The control structure already has fields for these values (netMask, gatewayAddress, dnsServerAddress) but they were never populated from the DHCP response. Fixes Microchip-MPLAB-Harmony#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the DHCP callback handler to properly extract all network configuration fields from the DHCP response, not just the IP address.
Problem
The WINC driver's DHCP callback handler (
M2M_WIFI_REQ_DHCP_CONF) incorrectly casts the message content touint8_t*and only extracts 4 bytes (IP address), even though the WINC firmware provides complete network configuration in thetstrM2MIPConfigstructure.Solution
tstrM2MIPConfig*Technical Details
The control structure already has fields for these values (netMask, gatewayAddress, dnsServerAddress) but they were never populated from the DHCP response. This change ensures applications can access complete network configuration obtained via DHCP.
Testing
Fixes #4
References