Save in main thread #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2018 15:09
…for save on close dialog"" This reverts commit 8f9fe07.
vladbenchea
approved these changes
Apr 25, 2018
paul-ciobanu
suggested changes
Apr 26, 2018
|
|
||
| //This will stop the window from closing if an error occurs | ||
| //when saving from the dialog that appears when you close a dirty tab | ||
| monitor.setCanceled(true); |
There was a problem hiding this comment.
@atothhpe Looking at the code, it seems that doSave is only called twice and with null as a param.
monitor.setCanceled(true); will definitely throw an exception.
What will happen to "updateEntityJob.join(1000 * 10, monitor);" when monitor is null?
There was a problem hiding this comment.
updateEntityJob.join(1000 * 10, monitor); can have a null monitor param
There was a problem hiding this comment.
The monitor for the doSave is provided from the platfrom, sadly I have no idea where to get it from.
monitor.setCancelled is a problem, I need to find another way to keep the tab from closing on error
|
@paul-ciobanu ok, I think i fixed it |
paul-ciobanu
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doSave() method now locks the UI thread. Has a 10 second timeout.
This is needed for the save before close dialog to work.
If the save method would not block, the editor would close before save operation would finish