-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fields #22
Update fields #22
Conversation
…plugin into update-fields
git@github.com:HPSoftware/octane-eclipse-plugin.git into update-fields Conflicts: octane-eclipse-plugin/src/com/hpe/octane/ideplugins/eclipse/ui/editor/EntityModelEditor.java
adding different ones
the fields displayed. Fixed bug where description field would start collapsed
to the defect #573056)
Composites in Entity details view
…pse-plugin.git into update-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls
octane-eclipse-plugin/plugin.xml
Outdated
@@ -69,8 +69,8 @@ | |||
point="org.eclipse.ui.editors"> | |||
<editor | |||
class="com.hpe.octane.ideplugins.eclipse.ui.editor.EntityModelEditor" | |||
id="com.hpe.octane.ideplugins.eclipse.ui.EntityModelEditor" | |||
name="EntityModelEditor"> | |||
id="com.hpe.octane.ideplugins.eclipse.ui.editor2.EntityModelEditorNew" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
editor2 -> editor
octane-eclipse-plugin/plugin.xml
Outdated
id="com.hpe.octane.ideplugins.eclipse.ui.EntityModelEditor" | ||
name="EntityModelEditor"> | ||
id="com.hpe.octane.ideplugins.eclipse.ui.editor2.EntityModelEditorNew" | ||
name="EntityModelEditorNew"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naming
|
||
public void setEntityModel(EntityModel entityModel) { | ||
this.entityModel = entityModel; | ||
commentText.setEnabled(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting?
@@ -49,7 +49,8 @@ | |||
NO_ITEMS_TO_DISPLAY_ROBOT("s-no-items-to-display.png"), | |||
UNIDRAG_SMALL("unidrag-small.png"), | |||
ROCKET("s-rocket.png"), | |||
NO_RESULTS_ROBOT("s-no-items-to-display.png"); | |||
NO_RESULTS_ROBOT("s-no-items-to-display.png"), | |||
SHOW_COMMENTS("comments-16x16.png"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls check for unused images
pom.xml
Outdated
@@ -106,7 +117,8 @@ | |||
</plugins> | |||
<pluginManagement> | |||
<plugins> | |||
<!--This plugin's configuration is used to store Eclipse m2e settings only. It has no influence on the Maven build itself.--> | |||
<!--This plugin's configuration is used to store Eclipse m2e settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one line pls
Name of branch isn't suggestive, it's actually refactoring.