Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fields #22

Merged
merged 42 commits into from
Mar 2, 2018
Merged

Update fields #22

merged 42 commits into from
Mar 2, 2018

Conversation

vladbenchea
Copy link
Collaborator

Name of branch isn't suggestive, it's actually refactoring.

Andras Toth and others added 30 commits January 11, 2018 15:13
git@github.com:HPSoftware/octane-eclipse-plugin.git into update-fields

Conflicts:
	octane-eclipse-plugin/src/com/hpe/octane/ideplugins/eclipse/ui/editor/EntityModelEditor.java
the fields displayed. Fixed bug where description field would start
collapsed
Copy link

@andrast0th andrast0th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls

@@ -69,8 +69,8 @@
point="org.eclipse.ui.editors">
<editor
class="com.hpe.octane.ideplugins.eclipse.ui.editor.EntityModelEditor"
id="com.hpe.octane.ideplugins.eclipse.ui.EntityModelEditor"
name="EntityModelEditor">
id="com.hpe.octane.ideplugins.eclipse.ui.editor2.EntityModelEditorNew"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editor2 -> editor

id="com.hpe.octane.ideplugins.eclipse.ui.EntityModelEditor"
name="EntityModelEditor">
id="com.hpe.octane.ideplugins.eclipse.ui.editor2.EntityModelEditorNew"
name="EntityModelEditorNew">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming


public void setEntityModel(EntityModel entityModel) {
this.entityModel = entityModel;
commentText.setEnabled(true);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting?

@@ -49,7 +49,8 @@
NO_ITEMS_TO_DISPLAY_ROBOT("s-no-items-to-display.png"),
UNIDRAG_SMALL("unidrag-small.png"),
ROCKET("s-rocket.png"),
NO_RESULTS_ROBOT("s-no-items-to-display.png");
NO_RESULTS_ROBOT("s-no-items-to-display.png"),
SHOW_COMMENTS("comments-16x16.png");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check for unused images

pom.xml Outdated
@@ -106,7 +117,8 @@
</plugins>
<pluginManagement>
<plugins>
<!--This plugin's configuration is used to store Eclipse m2e settings only. It has no influence on the Maven build itself.-->
<!--This plugin's configuration is used to store Eclipse m2e settings

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one line pls

@vladbenchea vladbenchea merged commit 95fd80c into master Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants